Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure on 0.1.3 upgrade: executable that is Buildable: False #763

Closed
gregwebs opened this issue Aug 11, 2015 · 13 comments
Closed

failure on 0.1.3 upgrade: executable that is Buildable: False #763

gregwebs opened this issue Aug 11, 2015 · 13 comments
Assignees

Comments

@gregwebs
Copy link
Contributor

@gregwebs gregwebs commented Aug 11, 2015

Our CI server automatically upgrades to new releases and this happened:

NOTE: the test command is functionally equivalent to 'build --test'
Progress: 0/11                                          frontrow-entities-0.0.1.1: configure
Progress: 0/11                                          frontrow-entities-0.0.1.1: build
Progress: 0/11                                          P
--  While building package frontrow-entities-0.0.1.1 using:
      /opt/ghc/7.8.4/bin/runhaskell -package=Cabal-1.18.1.5 -clear-package-db -global-package-db -package-db=/home/ubuntu/.stack/snapshots/x86_64-linux/lts-2.3/7.8.4/pkgdb/ /tmp/stack14295/Setup.hs --builddir=.stack-work/dist/x86_64-linux/Cabal-1.18.1.5/ build exe:entities --ghc-options -hpcdir .stack-work/dist/x86_64-linux/Cabal-1.18.1.5/hpc/.hpc/ -ddump-hi -ddump-to-file
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/ubuntu/backend/.stack-work/logs/frontrow-entities-0.0.1.1.log

    Configuring frontrow-entities-0.0.1.1...
    Setup.hs: Cannot build the executable 'entities' because the component is
    marked as disabled in the .cabal file.

 stack test returned exit code 1

cabal file in question has this

executable    entities
  if flag(executable-too)
    Buildable: True
  else
    Buildable: False

This is a multi-cabal file project, and it works if I build just the individual cabal file.

fails: stack test
passes: stack test frontrow-entities

@gregwebs
Copy link
Contributor Author

@gregwebs gregwebs commented Aug 11, 2015

I did run stack clean before hand.

snoyberg added a commit that referenced this issue Aug 12, 2015
@snoyberg snoyberg self-assigned this Aug 12, 2015
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 12, 2015

Mea culpa, this was a bad mistake on my part, and needs to a hotfix released. Pinging @borsboom.

@gregwebs Can you test the 763-disabled-executable branch and confirm that it fixes things for you?

@borsboom That branch is a single commit on top of the 0.1.3.0 release tag, so should be easy to make a release for. Sorry for creating extra work for you here :(

@adinapoli
Copy link
Contributor

@adinapoli adinapoli commented Aug 12, 2015

I was hit by the very same issue during this morning upgrade - great to see Greg so quickly reporting it and Micheal so swiftly addressing the problem. Thank you guys!

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 12, 2015

@adinapoli Can you confirm that my branch fixes your problem? Confirmation will help us get the official release out faster.

@adinapoli
Copy link
Contributor

@adinapoli adinapoli commented Aug 12, 2015

@snoyberg Building your branch as we speak!

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 12, 2015

:)

@adinapoli
Copy link
Contributor

@adinapoli adinapoli commented Aug 12, 2015

Sorry, I had some cabal hell despite I was installing in a sandbox - it was trying to install a very old version of mono-traversable and vector-instances. I eventually got around it by using --allow-newer in my cabal install command. (go figure!)

I'm happy to report your patch did indeed the trick, and now my package builds successfully till the end. 🎉

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 12, 2015

Thanks!

I've been hit by that mono-traversable thing as well, I have no idea what cabal solver bug is triggering it unfortunately. I always just build stack with stack though, so I don't hit these problems often (the time I hit it was an old .travis.yml on a different project).

@adinapoli
Copy link
Contributor

@adinapoli adinapoli commented Aug 12, 2015

Glad it was not just me then! Hopefully this thread will be helpful to some other guy scratching his head on that.

@snoyberg snoyberg removed the in progress label Aug 12, 2015
@gregwebs
Copy link
Contributor Author

@gregwebs gregwebs commented Aug 12, 2015

Thanks for the quick fix! Can you push the tag for the new version?

@borsboom
Copy link
Contributor

@borsboom borsboom commented Aug 12, 2015

Just waiting on a few more binaries to finish their builds and integration tests, then I'll publish the Github release (which will create the tag).

@borsboom
Copy link
Contributor

@borsboom borsboom commented Aug 12, 2015

Tag is pushed, and package uploaded to hackage. RPM/DEB packages being built and uploaded, will appear on the APT/YUM repos over the next hour or so.

@gregwebs
Copy link
Contributor Author

@gregwebs gregwebs commented Aug 12, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.