Ignoring stack-built ghc executables when looking for compiler for Setup.hs (#1052).
#1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should not be included (commercialhaskell#1052).
| -- https://github.com/commercialhaskell/stack/issues/1052 | ||
| menvWithoutLocals <- liftIO $ configEnvOverride config envSettings { esIncludeLocals = False } | ||
| getGhcPath <- runOnce $ liftIO $ join $ findExecutable menvWithoutLocals "ghc" | ||
| getGhcjsPath <- runOnce $ liftIO $ join $ findExecutable menvWithoutLocals "ghcjs" |
There was a problem hiding this comment.
@mgsloan Can you confirm if the local database should or shouldn't be used for finding the ghcjs executable?
There was a problem hiding this comment.
Right, it makes sense to exclude locals for resolving the ghcjs binary as well.
snoyberg
added a commit
that referenced
this pull request
Oct 22, 2015
Ignoring stack-built `ghc` executables when looking for compiler for Setup.hs (#1052).
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #1052 was once fixed but got broken again when compiling custom
Setup.hshas been implemented — see #1052 (comment). This PR fixes this by excluding local extra bin directories from lookup when searching for GHC to compileSetup.hswith.