New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extra-package-dbs in 'stack ghci' #1229

Merged
merged 1 commit into from Nov 14, 2015

Conversation

Projects
None yet
3 participants
@vigoo
Contributor

vigoo commented Oct 25, 2015

An addition to the extra-package-dbs option (#990), to pass the extra package databases in the stack ghci command too.

@borsboom

This comment has been minimized.

Contributor

borsboom commented Oct 25, 2015

LGTM.

@chrisdone, can review this, since you're more familiar with stack ghci?

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Nov 8, 2015

I've taken a look at this, and I think it should be done a different way.

Note that currently nothing about the package databases is passed to GHCi, yet it works as it should. This is because we're essentially running it via stack exec which sets various environment variables. In particular, it sets GHC_PACKAGE_PATH.

So, I think the best way to fix this (and fix other things along with it!) is to include the extra-package-dbs in GHC_PACKAGE_PATH. This will involve adding an extra argument to mkGhcPackagePath.

@vigoo vigoo force-pushed the vigoo:extra-pkg-dbs-ghci branch from 374d5d7 to f2f50a6 Nov 12, 2015

Support for extra-package-dbs in 'stack ghci'
Extra package dbs support for GHC_PACKAGE_PATH

@vigoo vigoo force-pushed the vigoo:extra-pkg-dbs-ghci branch from f2f50a6 to 4799edc Nov 12, 2015

@vigoo

This comment has been minimized.

Contributor

vigoo commented Nov 12, 2015

I've rewritten this PR based on @mgsloan 's comment. Please review.

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Nov 14, 2015

Looks good to me, thanks!

mgsloan added a commit that referenced this pull request Nov 14, 2015

Merge pull request #1229 from vigoo/extra-pkg-dbs-ghci
Support for extra-package-dbs in 'stack ghci'

@mgsloan mgsloan merged commit 05f4c76 into commercialhaskell:master Nov 14, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment