Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extra-package-dbs in 'stack ghci' #1229

merged 1 commit into from Nov 14, 2015


Copy link

@vigoo vigoo commented Oct 25, 2015

An addition to the extra-package-dbs option (#990), to pass the extra package databases in the stack ghci command too.

Copy link


@chrisdone, can review this, since you're more familiar with stack ghci?

Copy link

mgsloan commented Nov 8, 2015

I've taken a look at this, and I think it should be done a different way.

Note that currently nothing about the package databases is passed to GHCi, yet it works as it should. This is because we're essentially running it via stack exec which sets various environment variables. In particular, it sets GHC_PACKAGE_PATH.

So, I think the best way to fix this (and fix other things along with it!) is to include the extra-package-dbs in GHC_PACKAGE_PATH. This will involve adding an extra argument to mkGhcPackagePath.

Extra package dbs support for GHC_PACKAGE_PATH
Copy link
Contributor Author

vigoo commented Nov 12, 2015

I've rewritten this PR based on @mgsloan 's comment. Please review.

Copy link

mgsloan commented Nov 14, 2015

Looks good to me, thanks!

mgsloan added a commit that referenced this pull request Nov 14, 2015
Support for extra-package-dbs in 'stack ghci'
@mgsloan mgsloan merged commit 05f4c76 into commercialhaskell:master Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants