Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCabal file Git SHA #2070
Conversation
snoyberg
added
the
in progress
label
Apr 27, 2016
This comment has been minimized.
This comment has been minimized.
|
@snoyberg LGTM! I pushed a fix to the build for 7.8 |
mgsloan
referenced this pull request
Apr 29, 2016
Open
Avoid loading hackage index cache for extra-deps which are already installed? #2081
snoyberg
and others
added some commits
Apr 26, 2016
snoyberg
force-pushed the
cabal-file-git-sha
branch
from
47b3913
to
e18d8b5
May 3, 2016
This comment has been minimized.
This comment has been minimized.
|
LGTM! |
mgsloan
merged commit 23386c4
into
master
May 4, 2016
borsboom
removed
the
in progress
label
May 4, 2016
bergmark
referenced this pull request
Jun 10, 2016
Open
new dependency for linear-1.18.3 broke our lts-based builds #108
borsboom
deleted the
cabal-file-git-sha
branch
Aug 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
snoyberg commentedApr 27, 2016
This patch turned out to be much larger than expected, and mostly for tedious reasons. I recommend reviewing one commit at a time, as two of these are very mechanical (changing constraints and adding fields to some data types).
I added support to stackage-curator recently to include hashes of .cabal files for newly generated snapshots. This patch will ensure that, when using Git as a package index and a snapshot with this hash information, we get the same version of the .cabal file as was used when generating the snapshot, avoiding the possibility of Hackage edits from corrupting the snapshot for end users.
I recommend holding off on merging this for a few days so it can be properly tested with upstream Stackage Nightly snapshots that actually have this .cabal hash information.