New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal file Git SHA #2070

Merged
merged 6 commits into from May 4, 2016

Conversation

Projects
None yet
3 participants
@snoyberg
Contributor

snoyberg commented Apr 27, 2016

This patch turned out to be much larger than expected, and mostly for tedious reasons. I recommend reviewing one commit at a time, as two of these are very mechanical (changing constraints and adding fields to some data types).

I added support to stackage-curator recently to include hashes of .cabal files for newly generated snapshots. This patch will ensure that, when using Git as a package index and a snapshot with this hash information, we get the same version of the .cabal file as was used when generating the snapshot, avoiding the possibility of Hackage edits from corrupting the snapshot for end users.

I recommend holding off on merging this for a few days so it can be properly tested with upstream Stackage Nightly snapshots that actually have this .cabal hash information.

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Apr 28, 2016

@snoyberg LGTM! I pushed a fix to the build for 7.8

@snoyberg snoyberg force-pushed the cabal-file-git-sha branch from 47b3913 to e18d8b5 May 3, 2016

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented May 4, 2016

LGTM!

@mgsloan mgsloan merged commit 23386c4 into master May 4, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@borsboom borsboom removed the in progress label May 4, 2016

@borsboom borsboom deleted the cabal-file-git-sha branch Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment