Cabal file Git SHA #2070
Merged
Cabal file Git SHA #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snoyberg LGTM! I pushed a fix to the build for 7.8 |
snoyberg
force-pushed
the
cabal-file-git-sha
branch
from
47b3913
to
e18d8b5
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch turned out to be much larger than expected, and mostly for tedious reasons. I recommend reviewing one commit at a time, as two of these are very mechanical (changing constraints and adding fields to some data types).
I added support to stackage-curator recently to include hashes of .cabal files for newly generated snapshots. This patch will ensure that, when using Git as a package index and a snapshot with this hash information, we get the same version of the .cabal file as was used when generating the snapshot, avoiding the possibility of Hackage edits from corrupting the snapshot for end users.
I recommend holding off on merging this for a few days so it can be properly tested with upstream Stackage Nightly snapshots that actually have this .cabal hash information.