Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upstack sdist: Fix timestamp in tarball #2394
Conversation
This comment has been minimized.
This comment has been minimized.
|
LGTM, thanks! |
mgsloan
merged commit c754432
into
commercialhaskell:master
Jul 19, 2016
Blaisorblade
deleted the
Blaisorblade:sdist-timestamps
branch
Jul 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Blaisorblade commentedJul 19, 2016
Here tar (the tool) warns on Travis that a time stamp in a tarball generated by stack sdist is very odd:
The warning is harmless, but it might still puzzle users (e.g. http://raspberrypi.stackexchange.com/a/13152/4395 in other scenarios), so here's a 2-line fix.