Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download snapshots.json from S3 #2653

Merged
merged 1 commit into from Oct 4, 2016
Merged

Download snapshots.json from S3 #2653

merged 1 commit into from Oct 4, 2016

Conversation

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Sep 30, 2016

S3 is more reliable than stackage.org. See discussion:
https://www.reddit.com/r/haskell/comments/556a43/stackageorg_down/d8818rh

S3 is more reliable than stackage.org. See discussion:
https://www.reddit.com/r/haskell/comments/556a43/stackageorg_down/d8818rh
@sjakobi
Copy link
Member

@sjakobi sjakobi commented Oct 3, 2016

Noob question: Does it matter that S3 serves the file with Content-Type: binary/octet-stream while stackage used Content-Type: application/json; charset=utf-8?

A changelog entry would be good too, but I can add one myself.

@sjakobi
Copy link
Member

@sjakobi sjakobi commented Oct 3, 2016

Oh, and the Travis failure can be ignored. The compile failure was introduced elsewhere and has since been fixed.

@mgsloan mgsloan merged commit b39a070 into master Oct 4, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Oct 4, 2016

LGTM!

@snoyberg
Copy link
Contributor Author

@snoyberg snoyberg commented Oct 4, 2016

It won't break this, but it's worth fixing anyway, I'll add a note for
myself.

On Tue, Oct 4, 2016, 4:49 AM Michael Sloan notifications@github.com wrote:

LGTM!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBB632Pl7gym6vJzq3QIf8gASAjX5Uks5qwbDBgaJpZM4KK17U
.

@sjakobi sjakobi deleted the snapshots-from-s3 branch Oct 6, 2016
sjakobi added a commit that referenced this pull request Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.