Download snapshots.json from S3 #2653

Merged
merged 1 commit into from Oct 4, 2016

Projects

None yet

3 participants

@snoyberg
Contributor

S3 is more reliable than stackage.org. See discussion:
https://www.reddit.com/r/haskell/comments/556a43/stackageorg_down/d8818rh

@snoyberg snoyberg Download snapshots.json from S3
S3 is more reliable than stackage.org. See discussion:
https://www.reddit.com/r/haskell/comments/556a43/stackageorg_down/d8818rh
93c33c9
@sjakobi
Contributor
sjakobi commented Oct 3, 2016

Noob question: Does it matter that S3 serves the file with Content-Type: binary/octet-stream while stackage used Content-Type: application/json; charset=utf-8?

A changelog entry would be good too, but I can add one myself.

@sjakobi
Contributor
sjakobi commented Oct 3, 2016

Oh, and the Travis failure can be ignored. The compile failure was introduced elsewhere and has since been fixed.

@mgsloan mgsloan merged commit b39a070 into master Oct 4, 2016

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgsloan
Collaborator
mgsloan commented Oct 4, 2016

LGTM!

@snoyberg
Contributor
snoyberg commented Oct 4, 2016

It won't break this, but it's worth fixing anyway, I'll add a note for
myself.

On Tue, Oct 4, 2016, 4:49 AM Michael Sloan notifications@github.com wrote:

LGTM!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADBB632Pl7gym6vJzq3QIf8gASAjX5Uks5qwbDBgaJpZM4KK17U
.

@sjakobi sjakobi deleted the snapshots-from-s3 branch Oct 6, 2016
@sjakobi sjakobi added a commit that referenced this pull request Oct 6, 2016
@sjakobi sjakobi Amend changelog for #2653 7b167ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment