Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `--global` flag for suitable `stack config set` fields #2675

Merged
merged 2 commits into from Oct 6, 2016

Conversation

@sjakobi
Copy link
Member

@sjakobi sjakobi commented Oct 5, 2016

Needed for #2537.

@sjakobi
Copy link
Member Author

@sjakobi sjakobi commented Oct 5, 2016

I couldn't figure out how to add the --global flag to the existing monadic argument parser for the field and value, so I decided to use subcommand parsers for the fields instead.

@sjakobi
Copy link
Member Author

@sjakobi sjakobi commented Oct 5, 2016

The Travis errors seem to be unrelated to the change, I have opened travis-ci/travis-ci#6680 for them.

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Oct 6, 2016

Looks like a great change to me! Thanks!

@mgsloan mgsloan merged commit d771cd6 into master Oct 6, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sjakobi sjakobi deleted the stack-config-set-global branch Oct 6, 2016
sjakobi added a commit that referenced this pull request Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.