Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filtering of ghc messages #3127

Merged
merged 4 commits into from
Jun 6, 2017
Merged

Improve filtering of ghc messages #3127

merged 4 commits into from
Jun 6, 2017

Conversation

sergv
Copy link
Contributor

@sergv sergv commented Apr 14, 2017

I added stripping of linker warnings on ghc 7.8 on windows (x64 IIRC). I'm not sure how useful it would be in general going forwards, but it's really annoying when it occurs.

I also took liberty to improve Stack.Build.Execute module a bit by adding type signatures no non-obvious parts and by introducing (hopefully) descriptive enums instead of booleans.

@mgsloan
Copy link
Contributor

mgsloan commented Apr 23, 2017

@sergv Thanks for working on this, I like the cleanups! Are these warnings sure to be spurious? Perhaps the filtering should only be done when we know we're using ghc 7.8?

@sergv
Copy link
Contributor Author

sergv commented Apr 23, 2017

@mgsloan The warnings are only visible on windows x64 and are definitely uninteresting as they don't affect the executables produced. I agree that it's good idea to only filter them for ghc 7.8. I'll prepare a followup patch in this PR soon.

@sergv
Copy link
Contributor Author

sergv commented Apr 24, 2017

@mgsloan I've rebased the branch and ensured that filtering happens only for ghcs below 7.10.

@mgsloan mgsloan merged commit 06de280 into commercialhaskell:master Jun 6, 2017
@mgsloan
Copy link
Contributor

mgsloan commented Jun 6, 2017

@sergv Sorry for taking so long to get this merged! Will try to be more on it in the future.

mgsloan added a commit that referenced this pull request Jun 6, 2017
@sergv
Copy link
Contributor Author

sergv commented Jun 6, 2017

@mgsloan Thanks for merging it anyway! It's reassuring to know than PR will be merged at some point, even if not so quickly.

@decentral1se
Copy link
Member

I also took liberty to improve Stack.Build.Execute module a bit by adding type signatures no non-obvious parts and by introducing (hopefully) descriptive enums instead of booleans.

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants