Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --no-rerun-tests #3770

Merged
merged 2 commits into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@snoyberg
Copy link
Contributor

snoyberg commented Jan 14, 2018

Demonstrates that --no-rerun-tests does not work, and tests are in fact
still rerun.

NOTE DO NOT MERGE yet. We still need to fix this, the test case just fails for now.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@neongreen

This comment has been minimized.

Copy link
Collaborator

neongreen commented Jan 24, 2018

I'd like to fix this one, it looks easy. Please ping if somebody else is already working on it :)

@snoyberg

This comment has been minimized.

Copy link
Contributor Author

snoyberg commented Jan 24, 2018

@neongreen

This comment has been minimized.

Copy link
Collaborator

neongreen commented Jan 24, 2018

Okay, this is when it broke: d501148#diff-890614cc04afa326f5d48aac897e4aa8L1270

@mgsloan what was the rationale for removing the call to setTestSuccess? Can I just resurrect it in singleTest, or should it be somewhere else?

@neongreen

This comment has been minimized.

Copy link
Collaborator

neongreen commented Jan 24, 2018

@snoyberg by the way, can I get write access? (To be able to push a fix to the same branch where the failing test is)

@snoyberg

This comment has been minimized.

Copy link
Contributor Author

snoyberg commented Jan 24, 2018

Good find! And write access granted.

@snoyberg

This comment has been minimized.

Copy link
Contributor Author

snoyberg commented Jan 24, 2018

Also, you should probably rebase this. And since it looks to be a relatively small patch, putting it on the stable branch is probably worthwhile.

Failing test case for no-rerun-tests
Demonstrates that --no-rerun-tests does not work, and tests are in fact
still rerun.
@mgsloan

This comment has been minimized.

Copy link
Collaborator

mgsloan commented Jan 24, 2018

@neongreen Impressed that you found the commit that caused this, my mistake! It was 2 years ago, I don't recall why that change ended up in the commit.

@neongreen neongreen force-pushed the no-rerun-tests branch from ea90952 to ddad2df Jan 24, 2018

@neongreen neongreen changed the base branch from master to stable Jan 24, 2018

@neongreen

This comment has been minimized.

Copy link
Collaborator

neongreen commented Jan 24, 2018

Alright, the test passes for me (at least locally) – waiting for CI to run all integration tests because ain't nobody got enough patience to run integration tests locally

@neongreen

This comment has been minimized.

Copy link
Collaborator

neongreen commented Jan 24, 2018

Is the Travis failure okay? I'm not sure – seems to be a missing script, not a problem with this PR.

If yes, I'll add a changelog entry and merge this PR (barring any other objections).

@snoyberg

This comment has been minimized.

Copy link
Contributor Author

snoyberg commented Jan 24, 2018

I'm pretty sure Travis just got confused, and did a merge with master instead of stable. Since the push Travis job succeeded, I think it's OK to do the changelog update and then merge.

@neongreen neongreen changed the title Failing test case for no-rerun-tests Fix --no-rerun-tests Jan 25, 2018

@neongreen neongreen force-pushed the no-rerun-tests branch from ddad2df to 39ff251 Jan 25, 2018

@neongreen neongreen merged commit a573769 into stable Jan 25, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@neongreen neongreen deleted the no-rerun-tests branch Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.