Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize a new project only when no stack.yaml #3888

Merged
merged 2 commits into from Mar 14, 2018
Merged

Initialize a new project only when no stack.yaml #3888

merged 2 commits into from Mar 14, 2018

Conversation

gxmas
Copy link
Contributor

@gxmas gxmas commented Feb 23, 2018

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

stack new unpacks the project template and then initializes the unpacked project. When a project template contains a stack.yaml, initializing the project fails due to the presence of the stack.yaml files. Skip the initialization if the project template contains a stack.yaml.

The change was tested by using project templates that contain stack.yaml files.

When a project template contains a stack.yaml, initializing the
project fails due to the presence of the stack.yaml files.  Skip the
initialization if the template contains a stack.yaml.
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a comment to the ChangeLog about the change?

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just waiting on Travis

@snoyberg snoyberg merged commit 06406a9 into commercialhaskell:master Mar 14, 2018
@snoyberg
Copy link
Contributor

Merging despite Travis failure, since it's just a timeout that's already occurring on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants