New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ddump-dir option/config value #4225 #4242

Merged
merged 3 commits into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@waddlaw
Copy link
Contributor

waddlaw commented Aug 19, 2018

Fixes #4225

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@waddlaw waddlaw force-pushed the waddlaw:ddump-dir branch from 494d661 to 1275a84 Aug 19, 2018

@waddlaw waddlaw force-pushed the waddlaw:ddump-dir branch from 33fd73d to 539221f Aug 20, 2018

@waddlaw

This comment has been minimized.

Copy link
Contributor

waddlaw commented Aug 20, 2018

@snoyberg this should be all set now :)
Is this alright? Could you please confirm it?

@snoyberg
Copy link
Contributor

snoyberg left a comment

Looks like a great PR, just one minor comment.

-- copy ddump-* files
let enableDdumpDir = isJust $ boptsDdumpDir eeBuildOpts
ddumpPath = maybe "" T.unpack $ boptsDdumpDir eeBuildOpts
when (buildingFinals && enableDdumpDir && not (null ddumpPath)) $ do

This comment has been minimized.

@snoyberg

snoyberg Aug 20, 2018

Contributor

It looks like a pattern match would be easier to read here, e.g.:

case T.unpack <$> boptsDdumpDir eebuildOpts of
  Just ddumpPath | buildingFinals && enableDdumpDir && not (null ddumpPath) -> do ...
  _ -> pure ()

This comment has been minimized.

@waddlaw

waddlaw Aug 20, 2018

Contributor

That makes sense. That's true :)

@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Aug 20, 2018

LGTM. We can merge once CI passes.

@snoyberg snoyberg merged commit 87b0e7c into commercialhaskell:master Aug 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Aug 20, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment