New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile without a Git dir #4364 #4368

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@snoyberg
Copy link
Contributor

snoyberg commented Oct 21, 2018

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg snoyberg requested a review from borsboom Oct 21, 2018

@@ -298,7 +298,7 @@ executables:
- condition: ! '!(flag(disable-git-info))'
cpp-options: -DUSE_GIT_INFO
dependencies:
- githash
- githash >= 0.1.2

This comment has been minimized.

@borsboom

borsboom Oct 24, 2018

Contributor

We omit version constraints from package.yaml since they're implied by stack*.yaml. OK to leave for now though, since we do a sweep looking for any unnecessary constraints before release.

@dbaynard

This comment has been minimized.

Copy link
Contributor

dbaynard commented Nov 7, 2018

This can be merged, right?

@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Nov 7, 2018

Yes, I think so. Do you want me to do so, or did you want to?

@dbaynard dbaynard merged commit 96cc402 into stable Nov 7, 2018

1 of 3 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/gitlab/4364-no-git-dir Pipeline skipped on GitLab
Details
@borsboom

This comment has been minimized.

Copy link
Contributor

borsboom commented Nov 17, 2018

I cherry-picked this change into the release branch and made a hackage-only stack-1.9.1.1 release with it so that I could unblock stack in in Stackage. Some people still install it that way or with cabal install, and moreover I like that Stackage will inform me if the build breaks with newer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment