New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variables in filenames in templates #4381

merged 1 commit into from Nov 8, 2018


None yet
2 participants
Copy link

snoyberg commented Nov 1, 2018

Note: Documentation fixes for should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

New integration test added.

Copy link

mattaudesse left a comment

Looks good to me - I built + tested locally with the simple template as well.

I think we're all set to merge, right?

@mattaudesse mattaudesse self-assigned this Nov 8, 2018

@mattaudesse mattaudesse merged commit 7170704 into stable Nov 8, 2018

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
ci/gitlab/variables-in-template-file-names Pipeline skipped on GitLab
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment