New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mustache variables in template file names #4397

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@andrevdm
Copy link

andrevdm commented Nov 14, 2018

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Previously stack templates supported mustache variables in the file names, e.g. most often {-# START_FILE {{name}}.cabal #-}. With the 1.9.1 fix mustache expansion only happens in the file body and no longer in the names. This fix expands the file names as well.

Tested with a local template and several online ones e.g. scotty-hello-world. The .cabal files are now correctly named, i.e they are no longer named {{name}}.cabal

Fixes #4344 and #4395

@dbaynard

This comment has been minimized.

Copy link
Contributor

dbaynard commented Nov 14, 2018

Hi @andrevdm, thanks for the PR! Have you seen #4381? You're just a little too late, unfortunately. Does that meet your needs?

I'll make sure to close the original issue.

@andrevdm

This comment has been minimized.

Copy link

andrevdm commented Nov 14, 2018

Hi @dbaynard, that change looks perfect. Thanks

@andrevdm andrevdm closed this Nov 14, 2018

@dbaynard

This comment has been minimized.

Copy link
Contributor

dbaynard commented Nov 14, 2018

If you'd like to contribute beyond that, then please do — you're more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment