Don't error out on missing latest revision while constructing a build plan #4573
Conversation
| @@ -426,9 +426,15 @@ addDep treatAsDep' name = do | |||
| askPkgLoc = liftRIO $ do | |||
| mrev <- getLatestHackageRevision name version | |||
| case mrev of | |||
| Nothing -> error $ "No package revision found for: " <> show name | |||
| Nothing -> do | |||
| -- this could happen for GHC boot libraries missing from Hackage | |||
There was a problem hiding this comment.
I found a comment in another part of the code which cleared up my misunderstanding the other day.
stack/src/Stack/Build/Target.hs
Lines 315 to 318 in 12d11a6
So if stack doesn't find a revision, that's not a problem. If it does find a revision, it will use that. That's correct, then?
There was a problem hiding this comment.
Now when you ask it that way I'm not completely sure that it's 100% correct logic - the reason is that this PIOnlyInstalled should appear only for global libraries (GHC boot packages) and for those we don't have guarantees about proper versions/revisions on Hackage. From the other side as far as I understand we don't have any executables in those packages so practically tellExecutablesUpstream should be NOOP.
|
@dbaynard I've fixed it earlier yesterday while doing Stackage builds |
Please include the following checklist in your PR:
Tested manually.
Actually I've fixed it earlier in https://github.com/commercialhaskell/stack/tree/curator-stackage-build-with-stack as I caught it during Stackage build. And it was me who added it as a part of #4479 - sorry
Fixes #4572