Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-tests parameter to stack test #517

Merged
merged 1 commit into from Jul 7, 2015

Conversation

@JulianBirch
Copy link
Contributor

@JulianBirch JulianBirch commented Jul 4, 2015

New version of the PR addressing #430. Piggybacks on the toRun concept introduced in the last week now. No large scale splitting out of existing code.

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jul 6, 2015

This seems fine overall, but I think the naming is confusing. Perhaps --no-run-tests?

@JulianBirch
Copy link
Contributor Author

@JulianBirch JulianBirch commented Jul 6, 2015

Seems sensible. Will try to update it tonight.

On Monday, July 6, 2015, Michael Snoyman notifications@github.com wrote:

This seems fine overall, but I think the naming is confusing. Perhaps
--no-run-tests?


Reply to this email directly or view it on GitHub
#517 (comment)
.

Sent from an iPhone, please excuse brevity and typos.

@JulianBirch JulianBirch force-pushed the JulianBirch:master branch from ec4e269 to ff9d00c Jul 6, 2015
@JulianBirch JulianBirch force-pushed the JulianBirch:master branch from ff9d00c to 2b7fa64 Jul 6, 2015
@JulianBirch
Copy link
Contributor Author

@JulianBirch JulianBirch commented Jul 6, 2015

Here's a revised (and re-rebased) version.

snoyberg added a commit that referenced this pull request Jul 7, 2015
Add --no-tests parameter to stack test
@snoyberg snoyberg merged commit c2753e8 into commercialhaskell:master Jul 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jul 7, 2015

Thanks!

snoyberg added a commit that referenced this pull request Jul 7, 2015
@JulianBirch
Copy link
Contributor Author

@JulianBirch JulianBirch commented Jul 7, 2015

Thanks for all your help!

On Tuesday, July 7, 2015, Michael Snoyman notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#517 (comment)
.

Sent from an iPhone, please excuse brevity and typos.

dysinger added a commit that referenced this pull request Jul 8, 2015
* master:
  #279 Add retries (default 3) to verifiedDownload
  Upper limit on number of flag combinations to test #543
  Flip order of build and test/bench opts parser
  Move `boptsCoverage` and `boptsNoTests` to `TestOpts`
  Replace `boptsAdditionalArgs` with fields in `FinalAction`
  Add benchmark and test options to FinalAction
  Implement `stack bench --benchmark-arguments`
  Fix #537
  Targets outside of root dir don't build (fixes #366)
  Add changelog for #517
  Add --no-run-tests parameter to stack test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants