New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable hledger-lib test suite #2835

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
2 participants
@simonmichael
Contributor

simonmichael commented Sep 5, 2017

The issue was fixed in 1.3.1.

re-enable hledger-lib test suite
The issue was fixed in 1.3.1.

@lwm lwm merged commit 8d42525 into commercialhaskell:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lwm

This comment has been minimized.

Show comment
Hide comment
@lwm

lwm Sep 6, 2017

Member

@simonmichael, I am seeing the following build error now:

[40 of 45] Compiling Hledger.Read.CsvReader ( Hledger/Read/CsvReader.hs, dist/build/doctests/doctests-tmp/Hledger/Read/CsvReader.o )

Hledger/Read/CsvReader.hs:57:1: error:
    Could not find module ‘Text.Parsec’
    Use -v to see a list of the files searched for.
   |
57 | import qualified Text.Parsec as Parsec
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is that the original error? It may be the case that the build server isn't picking up the new version or something like that.

Member

lwm commented Sep 6, 2017

@simonmichael, I am seeing the following build error now:

[40 of 45] Compiling Hledger.Read.CsvReader ( Hledger/Read/CsvReader.hs, dist/build/doctests/doctests-tmp/Hledger/Read/CsvReader.o )

Hledger/Read/CsvReader.hs:57:1: error:
    Could not find module ‘Text.Parsec’
    Use -v to see a list of the files searched for.
   |
57 | import qualified Text.Parsec as Parsec
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is that the original error? It may be the case that the build server isn't picking up the new version or something like that.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Sep 6, 2017

Contributor

@lwm, no I think the original error was a missing time dep: simonmichael/hledger#596. I can't reproduce your CsvReader error here, and parsec is mentioned in build-depends for the doctests test suite.

Contributor

simonmichael commented Sep 6, 2017

@lwm, no I think the original error was a missing time dep: simonmichael/hledger#596. I can't reproduce your CsvReader error here, and parsec is mentioned in build-depends for the doctests test suite.

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Sep 6, 2017

Contributor

Surely it's not picking parsec < 3.0.0, which did not have the Text.Parsec module...

Contributor

simonmichael commented Sep 6, 2017

Surely it's not picking parsec < 3.0.0, which did not have the Text.Parsec module...

simonmichael added a commit to simonmichael/hledger that referenced this pull request Sep 6, 2017

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Sep 6, 2017

Contributor

Correction, I see my blunder and can reproduce. I'll release hledger-lib-1.3.2 shortly, and I guess a new build-constraints PR after that unless that's not required.

Contributor

simonmichael commented Sep 6, 2017

Correction, I see my blunder and can reproduce. I'll release hledger-lib-1.3.2 shortly, and I guess a new build-constraints PR after that unless that's not required.

@lwm

This comment has been minimized.

Show comment
Hide comment
@lwm

lwm Sep 6, 2017

Member

Thanks for looking into that @simonmichael! Since todays nightly is already out, I'll optimistically re-revert #2839 and then it should pick up the new release.

Member

lwm commented Sep 6, 2017

Thanks for looking into that @simonmichael! Since todays nightly is already out, I'll optimistically re-revert #2839 and then it should pick up the new release.

lwm added a commit that referenced this pull request Sep 6, 2017

@simonmichael

This comment has been minimized.

Show comment
Hide comment
@simonmichael

simonmichael Sep 6, 2017

Contributor
Contributor

simonmichael commented Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment