Merge pull request #50 from commit-0/lint-repo

Lint repo

Author: wenting-zhao

.github/workflows/system.yml

@@ -39,7 +39,7 @@ jobs:
           uv run commit0 evaluate --reference  --rebuild
           uv run commit0 evaluate --reference
       - name: Lint
-        run: uv run commit0 lint commit0/harness/lint.py
+        run: uv run commit0 lint commit0/harness/
       - name: Save
         env:
           GITHUB_TOKEN: ${{ secrets.MY_GITHUB_TOKEN }}

commit0/cli.py

@@ -1,6 +1,6 @@
 import typer
 from pathlib import Path
-from typing import List, Union
+from typing import Union
 from typing_extensions import Annotated
 import commit0.harness.run_pytest_ids
 import commit0.harness.get_pytest_ids
@@ -327,17 +327,24 @@ def evaluate(
 
 @commit0_app.command()
 def lint(
-    files: List[Path] = typer.Argument(..., help="Files to lint."),
+    repo_or_repo_dir: str = typer.Argument(
+        ..., help="Directory of the repository to test"
+    ),
+    commit0_dot_file_path: str = typer.Option(
+        ".commit0.yaml",
+        help="Path to the commit0 dot file, where the setup config is stored",
+    ),
 ) -> None:
     """Lint given files if provided, otherwise lint all files in the base directory."""
     check_commit0_path()
-    for path in files:
-        if not path.is_file():
-            raise FileNotFoundError(f"File not found: {str(path)}")
-    typer.echo(
-        f"Linting specific files: {', '.join(highlight(str(file), Colors.ORANGE) for file in files)}"
+    commit0_config = read_commit0_dot_file(commit0_dot_file_path)
+    typer.echo(f"Linting repo: {highlight(str(repo_or_repo_dir), Colors.ORANGE)}")
+    commit0.harness.lint.main(
+        commit0_config["dataset_name"],
+        commit0_config["dataset_split"],
+        repo_or_repo_dir,
+        commit0_config["base_dir"],
     )
-    commit0.harness.lint.main(files)
 
 
 @commit0_app.command()

commit0/harness/lint.py

@@ -1,7 +1,13 @@
 import subprocess
 import sys
+import os
+from datasets import load_dataset
 from pathlib import Path
-from typing import List
+from typing import Iterator
+
+from commit0.harness.constants import (
+    RepoInstance,
+)
 
 
 config = """repos:
@@ -28,7 +34,38 @@
     - id: pyright"""
 
 
-def main(files: List[Path]) -> None:
+def main(
+    dataset_name: str, dataset_split: str, repo_or_repo_dir: str, base_dir: str
+) -> None:
+    dataset: Iterator[RepoInstance] = load_dataset(dataset_name, split=dataset_split)  # type: ignore
+    example = None
+    repo_name = None
+    for example in dataset:
+        repo_name = example["repo"].split("/")[-1]
+        if repo_or_repo_dir.endswith("/"):
+            repo_or_repo_dir = repo_or_repo_dir[:-1]
+        if repo_name in os.path.basename(repo_or_repo_dir):
+            break
+    assert example is not None, "No example available"
+    assert repo_name is not None, "No repo available"
+
+    repo_dir = os.path.join(base_dir, repo_name)
+    if os.path.isdir(repo_or_repo_dir):
+        repo = repo_or_repo_dir
+    elif os.path.isdir(repo_dir):
+        repo = repo_dir
+    else:
+        raise Exception(
+            f"Neither {repo_dir} nor {repo_or_repo_dir} is a valid path.\nUsage: commit0 lint {{repo_or_repo_dir}}"
+        )
+
+    files = []
+    repo = os.path.join(repo, example["src_dir"])
+    for root, dirs, fs in os.walk(repo):
+        for file in fs:
+            if file.endswith(".py"):
+                files.append(os.path.join(root, file))
+
     config_file = Path(".commit0.pre-commit-config.yaml")
     if not config_file.is_file():
         config_file.write_text(config)