chore: Drop support for Node.js <6.x #566

LinusU · 2018-09-18T15:04:53Z

BREAKING CHANGE: Older versions of Node.js is no longer supported

Tried to go thru all of the breaking changes in sematic-release to get it up to date, hopefully I didn't miss anything 🙈

jimthedev · 2018-09-18T15:07:45Z

Very very excellent @LinusU

LinusU · 2018-09-18T15:19:44Z

Oh, I forgot to update appveyor 😄

jimthedev · 2018-09-18T15:23:19Z

Some day we should see how fast these are or if they could replace appveyor. https://azure.microsoft.com/en-us/services/devops/pipelines/

jimthedev · 2018-09-18T15:49:12Z

Travis isn't loading why the build failed so I am restarting it blindly.

jimthedev · 2018-09-18T15:50:22Z

Woah now they are failing fast and the logs just contain null. hmm

jimthedev · 2018-09-18T17:30:43Z

ok things seem to be working differently now that I cleared the travis cache. No idea what what broken but seems like it is a common issue.

LinusU · 2018-09-18T18:33:07Z

Upgraded to Babel 7 and took advantage of @babel/preset-env to only transpile what is necessary for Node.js 6.x, the transpiled code looks much better 🙌 🚀 should hopefully speed up the code a little bit ☺️

jimthedev · 2018-09-18T18:34:27Z

Excellent. PR looks good to me so feel free to self-merge when ready or continue to bring in a bunch of dep updates into this PR.

LinusU · 2018-09-19T09:21:30Z

I don't understand why the Appveyor build is failing 🤔 need to investigate some more 🧐

jimthedev · 2018-09-19T18:30:56Z

It looks like perhaps commitizen is finding an adapter when the tests requires that one isn't configured. Perhaps our tests aren't getting cleaned up properly on windows and thus an adapter is being left in place?

LinusU · 2018-09-19T21:12:56Z

Yeah, I don't really see how that can be though 🤔

The temp workspace should be located at test/.tmp/enduser-app and should be cleared at the beginning of the tests...

jimthedev · 2018-09-22T22:11:00Z

I was able to replicate it on my old ass windows machine. I haven't had a chance to work on it yet though because npm install took the better part of a day on this thing.

jimthedev · 2018-09-23T15:14:45Z

Ok I also added the azure builds because why the heck not. Let me know if you can get at them @LinusU. I can add you to the azure CI org. Nice to have cross OS builds in one place. https://dev.azure.com/commitizen/cz-cli/_build/results?buildId=7&view=logs

jimthedev · 2018-09-26T14:29:02Z

@LinusU, Good news! I have cz building on Azure DevOps on Ubuntu, Windows and OSX https://dev.azure.com/commitizen/cz-cli/_build/results?buildId=19&view=logs

Not sure what the semantic-release story looks like but at least we can have confidence in the builds. Next step would be to merge this into your modernize branch.

LinusU · 2018-09-26T14:55:08Z

Awesome 👏

Should I just rebase on master?

jimthedev · 2018-09-26T14:58:58Z

Yeah!

jimthedev · 2018-09-26T14:59:27Z

I am trying to find out how to get azure to show up in branch checks. I guess we'll see what runs when you rebase.

BREAKING CHANGE: Older versions of Node.js is no longer supported

jimthedev · 2018-09-26T16:48:44Z

I do! One thing is that currently azure devops is just using whatever node version happens to be on the boxes. I think they have nvm but there's less visibility into that without building some sort of matrix of builds using various node version.

jimthedev · 2018-09-26T17:30:35Z

I think we need something like this perhaps in our pipeline to grab artifactors, then we'd have a release job that actually takes those artifacts and runs the semantic release command against them. Obviously we'd only need one of the build artifacts to actually deploy to npm / github releases.

https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/publish-build-artifacts?view=vsts#yaml-snippet

LinusU · 2018-09-27T08:11:10Z

One thing is that currently azure devops is just using whatever node version happens to be on the boxes. I think they have nvm but there's less visibility into that without building some sort of matrix of builds using various node version.

Ah, right, it would be very nice to test on all supported versions: 6, 8, and 10.

Great to see some progress on this, thanks for all the help! 👏

jimthedev · 2018-09-27T10:24:39Z

🎉

jimthedev · 2018-09-29T16:58:10Z

Just a quick heads up and update that I am using this PR as the starting point to find whatever regression we're seeing. I am using modernize-part-deux and dep-updates branches to go back and forth while doing updates and watching the builds closely. So far I am not seeing where the Windows regression is coming in but when I find it I will post an update here.

jimthedev · 2018-09-30T01:26:15Z

Woah crazy. Looks like upgrading semantic-release broke this windows build. I don't understand haha.

jimthedev · 2018-09-30T13:47:36Z

Ok merged to master, sadly no release due to a 401 with semantic-release. My guess is an expired token or something. Will try to dig in but this alone closed a bunch of PRs. :)

jimthedev · 2018-10-01T14:57:52Z

FYI. Fixed semantic-release by updating tokens and this branch was released via Travis & semantic-release. Still have not upgraded it to latest as I will have to probably investigate further why it introduces that windows regression. For now our release process is that tests run in basically the same way they always did except that Azure has the best broad coverage while Travis is still doing releases when merging into master. For now that just means we need to be careful with our merges into master until we can have releases done through Azure and then can retire Travis.

jimthedev · 2018-10-01T15:02:17Z

One more note. Currently commitizen init seems to have issues so I have opened #572

3212: Update commitizen to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [commitizen](https://github.com/commitizen/cz-cli) was updated from `2.10.1` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v3.0.0</summary> <p><a name"3.0.0"></p> <h2>3.0.0 (2018-10-01)</h2> <h4>Bug Fixes</h4> <ul> <li>resolve linux build issues, add git exit code 128 warning (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c">c3764c8c</a>)</li> <li><strong>deps:</strong> <ul> <li>update dependency glob to v7.1.2 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327664" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#506" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/506">#506</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa824960">aa824960</a>)</li> <li>update dependency lodash to v4.17.10 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326338773" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#507" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/507">#507</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda9435">4bda9435</a>)</li> <li>update dependency find-root to v1.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327598" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#505" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/505">#505</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a">67a4e16a</a>)</li> <li>update dependency dedent to v0.7.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314146" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#504" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/504">#504</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a21b674f">a21b674f</a>)</li> <li>update dependency cz-conventional-changelog to v2.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314071" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#503" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/503">#503</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/43d54de1">43d54de1</a>)</li> </ul> </li> <li><strong>package:</strong> Remove opencollective post-install hook (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="356422024" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#561" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/561">#561</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d">a70c234d</a>)</li> </ul> <h4>Features</h4> <ul> <li>Drop support for Node.js <6.x, update dependencies (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="361350875" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#566" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/566">#566</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</li> <li>support initialization with yarn. (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="349367370" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#549" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/549">#549</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154">d5652154</a>, closes <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>, <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>)</li> </ul> <h4>Breaking Changes</h4> <ul> <li>Older versions of Node.js are no longer supported</li> </ul> <p>Includes most updates with the exception of semantic-release which breaks on windows. To be investigated in a later release.<br> (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</p> </details> <details> <summary>Commits</summary> <p>The new version differs by 23 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b06dbdf41af322dab06f83bfddd69149b"><code>a70c063</code></a> <code>feat: Drop support for Node.js <6.x, update dependencies (#566)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/0d76887b7853f673949cf7aee04653b90b4dda7b"><code>0d76887</code></a> <code>chore: remove sign from windows build</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/1546df4856dc8c4aa781e9e0ea755613647642ca"><code>1546df4</code></a> <code>chore: assume yarn in tests</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c1d2b05597a6c604c13b6a11731c47281"><code>c3764c8</code></a> <code>fix: resolve linux build issues, add git exit code 128 warning</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f1150c83a62048831fe6d94836f52242fdc9831e"><code>f1150c8</code></a> <code>chore: Create jobs build yml</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f0595edca921b68913e2ce2ca1bbad75abe71515"><code>f0595ed</code></a> <code>chore: add azure jobs</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4693079d0400ad1a914af86c6027f83d18cde74d"><code>4693079</code></a> <code>chore: Set up CI with Azure Pipelines</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154fa1bb41c1b1c84f20c620ee64ca32c78"><code>d565215</code></a> <code>feat: support initialization with yarn. fixes #527 (#549)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d8471af147cc9f7d9d090b6ba2192eb17"><code>a70c234</code></a> <code>fix(package): Remove opencollective post-install hook (#561)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5b8bc587770e4a7efd6a36962abaa0425931181"><code>d5b8bc5</code></a> <code>docs(readme): add npx use examples (#532)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d103b10f56121a8617ac9ac882338338417b0947"><code>d103b10</code></a> <code>chore(ci): test on Node.js 10.x (#531)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/41a921b002d1627cfedd4bb5745a27d8a47a5dfe"><code>41a921b</code></a> <code>BREAKING CHANGE: Remove Node 0.12 support (#524)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa8249605d45c1e95f57be7c832321212b0e8d1c"><code>aa82496</code></a> <code>fix(deps): update dependency glob to v7.1.2 (#506)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda94350625e54ca862cd143432de1912caea27"><code>4bda943</code></a> <code>fix(deps): update dependency lodash to v4.17.10 (#507)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a88c7925f3199996002ba8da37e420cff"><code>67a4e16</code></a> <code>fix(deps): update dependency find-root to v1.1.0 (#505)</code></li> </ul> <p>There are 23 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/commitizen/cz-cli/compare/5838ce007c1af2e71ef6ae68efce7682d59e9061...a70c063b06dbdf41af322dab06f83bfddd69149b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>

kaylangan · 2018-10-01T16:00:18Z

I'm a Program Manager on Azure Pipelines. Let me know if you have any questions or suggestions. Looks like you've made great progress!

jimthedev · 2018-10-01T16:08:09Z

@kaylangan thanks for stopping by! We're probably hammering the services as we migrate over so thank you very much for the open source plan. It really is a great service.

The only thing I can think of that is specific to the JavaScript community is that it would be helpful to understand why artifacts are separated out from builds. The key bring that in travis or other services you just throw semantic-release or npm publish into your yml file and then use things like travis-run-once or other tools to ensure that publish is only run once.

Artifacts is actually a better implementation here (I think) since you will only cut one release and would only do it if your builds work on your entire matrix (OSs and Node versions). The challenge I will be addressing next is that I currently am getting warnings that no files were found that could be copied into artifacts. I think once that is fixed then I will be able to run semantic-release / npm publish as an actual release against the artifacts. That will be the panacea. :)

jimthedev · 2018-10-01T20:32:28Z

@kaylangan another thing that would be great is the ability to style the pipeline badges or add some text in place of Azure Pipelines. While it is good advertising and a fine default, sometime you want to have one badge for master and one badge for latest/develop and it is useful to be able to see the name of that branch on the badge itself. Not critical, but a nice to have that others currently offer.

kaylangan · 2018-10-01T21:02:27Z

@kaylangan another thing that would be great is the ability to style the pipeline badges or add some text in place of Azure Pipelines. While it is good advertising and a fine default, sometime you want to have one badge for master and one badge for latest/develop and it is useful to be able to see the name of that branch on the badge itself. Not critical, but a nice to have that others currently offer.

You can use label= to specify other text. Even supports emojis!

jimthedev · 2018-10-01T21:04:43Z

@kaylangan another thing that would be great is the ability to style the pipeline badges or add some text in place of Azure Pipelines. While it is good advertising and a fine default, sometime you want to have one badge for master and one badge for latest/develop and it is useful to be able to see the name of that branch on the badge itself. Not critical, but a nice to have that others currently offer.

You can use label= to specify other text. Even supports emojis!

## The devDependency [commitizen](https://github.com/commitizen/cz-cli) was updated from `2.10.1` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v3.0.0</summary> <p><a name"3.0.0"></p> <h2>3.0.0 (2018-10-01)</h2> <h4>Bug Fixes</h4> <ul> <li>resolve linux build issues, add git exit code 128 warning (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c">c3764c8c</a>)</li> <li><strong>deps:</strong> <ul> <li>update dependency glob to v7.1.2 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327664" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#506" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/506">#506</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa824960">aa824960</a>)</li> <li>update dependency lodash to v4.17.10 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326338773" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#507" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/507">#507</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda9435">4bda9435</a>)</li> <li>update dependency find-root to v1.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326327598" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#505" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/505">#505</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a">67a4e16a</a>)</li> <li>update dependency dedent to v0.7.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314146" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#504" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/504">#504</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a21b674f">a21b674f</a>)</li> <li>update dependency cz-conventional-changelog to v2.1.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326314071" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#503" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/503">#503</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/43d54de1">43d54de1</a>)</li> </ul> </li> <li><strong>package:</strong> Remove opencollective post-install hook (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="356422024" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#561" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/561">#561</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d">a70c234d</a>)</li> </ul> <h4>Features</h4> <ul> <li>Drop support for Node.js <6.x, update dependencies (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="361350875" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#566" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/566">#566</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</li> <li>support initialization with yarn. (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="349367370" data-permission-text="Issue title is private" data-url="commitizen/cz-cli#549" href="https://urls.greenkeeper.io/commitizen/cz-cli/pull/549">#549</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154">d5652154</a>, closes <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>, <a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/527">#527</a>)</li> </ul> <h4>Breaking Changes</h4> <ul> <li>Older versions of Node.js are no longer supported</li> </ul> <p>Includes most updates with the exception of semantic-release which breaks on windows. To be investigated in a later release.<br> (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b">a70c063b</a>)</p> </details> <details> <summary>Commits</summary> <p>The new version differs by 23 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c063b06dbdf41af322dab06f83bfddd69149b"><code>a70c063</code></a> <code>feat: Drop support for Node.js <6.x, update dependencies (#566)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/0d76887b7853f673949cf7aee04653b90b4dda7b"><code>0d76887</code></a> <code>chore: remove sign from windows build</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/1546df4856dc8c4aa781e9e0ea755613647642ca"><code>1546df4</code></a> <code>chore: assume yarn in tests</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/c3764c8c1d2b05597a6c604c13b6a11731c47281"><code>c3764c8</code></a> <code>fix: resolve linux build issues, add git exit code 128 warning</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f1150c83a62048831fe6d94836f52242fdc9831e"><code>f1150c8</code></a> <code>chore: Create jobs build yml</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/f0595edca921b68913e2ce2ca1bbad75abe71515"><code>f0595ed</code></a> <code>chore: add azure jobs</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4693079d0400ad1a914af86c6027f83d18cde74d"><code>4693079</code></a> <code>chore: Set up CI with Azure Pipelines</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5652154fa1bb41c1b1c84f20c620ee64ca32c78"><code>d565215</code></a> <code>feat: support initialization with yarn. fixes #527 (#549)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/a70c234d8471af147cc9f7d9d090b6ba2192eb17"><code>a70c234</code></a> <code>fix(package): Remove opencollective post-install hook (#561)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d5b8bc587770e4a7efd6a36962abaa0425931181"><code>d5b8bc5</code></a> <code>docs(readme): add npx use examples (#532)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/d103b10f56121a8617ac9ac882338338417b0947"><code>d103b10</code></a> <code>chore(ci): test on Node.js 10.x (#531)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/41a921b002d1627cfedd4bb5745a27d8a47a5dfe"><code>41a921b</code></a> <code>BREAKING CHANGE: Remove Node 0.12 support (#524)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/aa8249605d45c1e95f57be7c832321212b0e8d1c"><code>aa82496</code></a> <code>fix(deps): update dependency glob to v7.1.2 (#506)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/4bda94350625e54ca862cd143432de1912caea27"><code>4bda943</code></a> <code>fix(deps): update dependency lodash to v4.17.10 (#507)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/67a4e16a88c7925f3199996002ba8da37e420cff"><code>67a4e16</code></a> <code>fix(deps): update dependency find-root to v1.1.0 (#505)</code></li> </ul> <p>There are 23 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/commitizen/cz-cli/compare/5838ce007c1af2e71ef6ae68efce7682d59e9061...a70c063b06dbdf41af322dab06f83bfddd69149b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

LinusU requested a review from jimthedev September 18, 2018 15:05

jimthedev approved these changes Sep 18, 2018

View changes

LinusU force-pushed the modernize branch from 779a74b to 7ece12c Compare September 18, 2018 18:44

LinusU added 10 commits September 26, 2018 16:33

chore: Drop support for Node.js <6.x

8c0b2a4

BREAKING CHANGE: Older versions of Node.js is no longer supported

chore: Update appveyor Node version

db7c7ee

chore: Upgrade to Babel 7.x

efd92b4

refactor: Avoid throwing literals

9800946

style: Remove passing lint disabler

7b60cbf

refactor: Avoid unused variables

7bd9f04

style: Remove trailing whitespace

17eb00a

refactor: Use path.join to concatenate paths

12ab8be

style: Avoid multiple empty lines

af56080

chore: Update to Shell.js 0.8.x

10add96

Example User added 3 commits September 26, 2018 19:46

fix: add artifact to build

9f9d15a

fix: add logging for existing adapters

967e128

fix: remove path-exists in favor of fs.existsSync

5a9674e

fix: add node.js matrix to build

88d6fef

fix: revert shelljs upgrade

455e5e9

fix: revert semantic-release update

141693a

jimthedev merged commit a70c063 into master Sep 30, 2018

dmwelch deleted the modernize branch July 27, 2021 15:28

chore: Drop support for Node.js <6.x #566

chore: Drop support for Node.js <6.x #566

LinusU commented Sep 18, 2018 •

edited

jimthedev commented Sep 18, 2018

LinusU commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

LinusU commented Sep 18, 2018

jimthedev commented Sep 18, 2018

LinusU commented Sep 19, 2018 •

edited

jimthedev commented Sep 19, 2018

LinusU commented Sep 19, 2018

jimthedev commented Sep 22, 2018

jimthedev commented Sep 23, 2018

jimthedev commented Sep 26, 2018 •

edited

LinusU commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

LinusU commented Sep 27, 2018

jimthedev commented Sep 27, 2018

jimthedev commented Sep 29, 2018

jimthedev commented Sep 30, 2018

jimthedev commented Sep 30, 2018

jimthedev commented Oct 1, 2018

jimthedev commented Oct 1, 2018

kaylangan commented Oct 1, 2018

jimthedev commented Oct 1, 2018

jimthedev commented Oct 1, 2018

kaylangan commented Oct 1, 2018

jimthedev commented Oct 1, 2018

chore: Drop support for Node.js <6.x #566

chore: Drop support for Node.js <6.x #566

Conversation

LinusU commented Sep 18, 2018 • edited

jimthedev commented Sep 18, 2018

LinusU commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

jimthedev commented Sep 18, 2018

LinusU commented Sep 18, 2018

jimthedev commented Sep 18, 2018

LinusU commented Sep 19, 2018 • edited

jimthedev commented Sep 19, 2018

LinusU commented Sep 19, 2018

jimthedev commented Sep 22, 2018

jimthedev commented Sep 23, 2018

jimthedev commented Sep 26, 2018 • edited

LinusU commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

jimthedev commented Sep 26, 2018

LinusU commented Sep 27, 2018

jimthedev commented Sep 27, 2018

jimthedev commented Sep 29, 2018

jimthedev commented Sep 30, 2018

jimthedev commented Sep 30, 2018

jimthedev commented Oct 1, 2018

jimthedev commented Oct 1, 2018

kaylangan commented Oct 1, 2018

jimthedev commented Oct 1, 2018

jimthedev commented Oct 1, 2018

kaylangan commented Oct 1, 2018

jimthedev commented Oct 1, 2018

LinusU commented Sep 18, 2018 •

edited

LinusU commented Sep 19, 2018 •

edited

jimthedev commented Sep 26, 2018 •

edited