Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for valid version of node / nodejs #254

Closed
mr-c opened this issue Dec 13, 2016 · 7 comments
Closed

check for valid version of node / nodejs #254

mr-c opened this issue Dec 13, 2016 · 7 comments

Comments

@mr-c
Copy link
Member

mr-c commented Dec 13, 2016

for example, v0.10.25 is too old
https://www.biostars.org/p/226909/#226917

@manu-chroma
Copy link
Member

manu-chroma commented Mar 15, 2017

if im not wrong, this would require making changes to cwltool/sandboxjs.py https://github.com/common-workflow-language/cwltool/blob/master/cwltool/sandboxjs.py#L33

after successful node detection, we need to check the version and if it's below the threshold, raise a runtime exception and exit the program. probably output a logging message before doing that.

@mr-c @tetron

@mr-c
Copy link
Member Author

mr-c commented Mar 16, 2017

@manu-chroma A good plan, yep!

@manu-chroma
Copy link
Member

any threshold version to check against?

currently setting it to v0.10.25

manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
@tetron
Copy link
Member

tetron commented Mar 16, 2017

The spec currently sets the minimum at ECMAScript 5.1, which seems to be well supported by Node.js 0.10.25. This is the version that ships in Ubuntu 14.04. Debian 8 ships with Node.js 0.10.29.

There's lots of goodies in ECMAScript 6+, but according to http://node.green/ you want to be using Node.js 6.0 or later to have good compliance with the standards.

We can consider bumping the requirement to ECMAScript 6 in the v1.1 spec.

manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 16, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
@manu-chroma
Copy link
Member

for the time being, what would you suggest should go in cwltool ?

should we stick to the current specification or set the minimum threshold version to Node.js 6.4.0 ?
i can open an issue in common-workflow-language/common-workflow-language for the same.

relevant PR: #337

@mr-c
Copy link
Member Author

mr-c commented Mar 20, 2017

@manu-chroma The minimum version to detect should be 0.10.25 as we are not changing the CWL specifications at this time.

manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 20, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 20, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
@manu-chroma
Copy link
Member

sticking to 0.10.25 for the PR then 😄

manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 21, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 22, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
qiukunlong pushed a commit to qiukunlong/cwltool that referenced this issue Mar 25, 2017
8d0fe99 Merge pull request common-workflow-language#254 from common-workflow-language/real-1.0
25a5565 Rename v1.0.dev4 to v1.0
f7617cc Add v1.0 as real valid version.
185953c Merge pull request common-workflow-language#253 from common-workflow-language/spec-cleanup
f9f2209 Simplify CommandLineTool
d0e774b simplify Process
a34a36e Merge pull request common-workflow-language#252 from common-workflow-language/description2doc

git-subtree-dir: cwltool/schemas
git-subtree-split: 8d0fe99
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 29, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
manu-chroma added a commit to manu-chroma/cwltool that referenced this issue Mar 29, 2017
- raises runtime exception if install node version is below
a threshold version.

- Fixes common-workflow-language#254
@mr-c mr-c closed this as completed in #337 May 25, 2017
tetron pushed a commit that referenced this issue Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants