New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes Extension #105

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mb21
Copy link

mb21 commented Sep 10, 2014

I realize this pull request may be a bit premature, but I wanted to put it out there for people to have a look and give feedback. (Otherwise just merge the typos.) Here's the proposal after running make spec.html.

This proposal was started on talk.commonmark.org and any substantial feedback on the attribute syntax should go there.

There is also a more general discussion about the standardization of extensions to 'core markdown'. For example, should this really be in the same document as the core spec, or should each extension get its own spec document?

@mb21 mb21 force-pushed the mb21:master branch 3 times, most recently from 59e3cd6 to f8ab541 Oct 6, 2014

@mb21 mb21 force-pushed the mb21:master branch from f8ab541 to 7c4e6bd Oct 17, 2014

@coding-horror

This comment has been minimized.

Copy link
Contributor

coding-horror commented Jun 4, 2016

I think you should rebase and merge in just the "non-space" vs "nonspace" and other simple textual changes first, and make a different pull request for the rest of it.

x = 1
```
.
<pre><code class="language-ruby">x = 1

This comment has been minimized.

@arve0

arve0 Oct 14, 2016

Should the expected output also contain the id code1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment