New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace image 'url' with 'destination' in DTD #512

Merged
merged 1 commit into from Mar 25, 2018

Conversation

Projects
None yet
2 participants
@ph1ll
Contributor

ph1ll commented Dec 10, 2017

The DTD defines a 'url' attribute for an image, however both cmark and CommonMark.js appear to use 'destination' instead (which is also consistent with a link).

http://spec.commonmark.org/dingus/

![foo](/url "title")
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE document SYSTEM "CommonMark.dtd">

<document xmlns="http://commonmark.org/xml/1.0">
  <paragraph>
    <image destination="/url" title="title">
      <text>foo</text>
    </image>
  </paragraph>
</document>

This MR updates the DTD to use 'destination' instead of 'url'. I couldn't see any other references in the spec indicating which attribute is actually correct, but if it is the case that cmark/commonmark.js are actually incorrect and not following the DTD, please close this.

@jgm jgm merged commit ba0855b into commonmark:master Mar 25, 2018

@jgm

This comment has been minimized.

Member

jgm commented Mar 25, 2018

Better late than never!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment