Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parsing of link/image urls with ( and space #177

Closed
jo-so opened this issue Nov 9, 2019 · 1 comment
Labels
bug

Comments

@jo-so
Copy link

@jo-so jo-so commented Nov 9, 2019

These two inputs become links:

[link](/u(ri )
[link](/u(ri
)
  1. https://spec.commonmark.org/dingus/?text=[link](%2Fu(ri%20)%0A
  2. https://spec.commonmark.org/dingus/?text=[link](%2Fu(ri%0A)%0A

But the spec says:

A link destination consists of either
...

  • a nonempty sequence of characters that does not start with <, does not include ASCII space or control characters, and includes parentheses only if (a) they are backslash-escaped or (b) they are part of a balanced pair of unescaped parentheses. (Implementations may impose limits on parentheses nesting to avoid performance issues, but at least three levels of nesting should be supported.)
@jgm

This comment has been minimized.

Copy link
Member

@jgm jgm commented Nov 11, 2019

This also appears to be an issue with commonmark/cmark and jgm/commonmark-hs.

@jgm jgm added the bug label Nov 11, 2019
jgm added a commit to commonmark/commonmark-spec that referenced this issue Nov 11, 2019
@jgm jgm closed this in 7bf19e8 Nov 11, 2019
jgm added a commit to jgm/commonmark-hs that referenced this issue Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.