New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user takes a photo, send push notification - "Is this a picture of A/B/C? Is it in administrative area D/E/F? (then link Wikidata/Commons)" #259

Open
magnusmanske opened this Issue Sep 5, 2016 · 22 comments

Comments

Projects
5 participants
@magnusmanske

magnusmanske commented Sep 5, 2016

How about when the user take an image to upload, the location is checked against Wikidata items without image nearby (say, 200m), and then presents a list of all these under the heading "Is this a picture of..."?
Likewise, items near the location can give you a "administrative area", or at least a very short list thereof; follow that Wikidata list to "higher" units, and present the lowest one with a Commons category, as a "location category".

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented Sep 5, 2016

Hello,
Great honour to receive feedback from you!
That's a great idea :-)

We happen to download a database of nearby points already in the app. But since 1) We are currently loading the whole nearby data but will switch to adhoc area-centered requests as soon as we can 2) Wikidata items missing requested pictures vastly outnumber wikipedia requested picture tags; we could also query Wikidata directly with something like this.

@nemobis

This comment has been minimized.

Contributor

nemobis commented Sep 5, 2016

How about when the user take an image to upload, the location is checked against Wikidata items without image nearby (say, 200m)

I also proposed this at https://phabricator.wikimedia.org/T143884

@misaochan

This comment has been minimized.

Member

misaochan commented Sep 6, 2016

Love the idea!

Is the Wikipedia app already interested in taking this on? (since I noticed that they were tagged in the Phab task).

@nicolas-raoul nicolas-raoul changed the title from "Reverse nearby" to Notify about nearby Wikidata items without an image Sep 7, 2016

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented Sep 7, 2016

See also: #79 Notify about nearby picture requests

@misaochan

This comment has been minimized.

Member

misaochan commented Dec 8, 2016

Relevant suggestion by Mark Traceur on nemo's Phab task:

A word of caution...if you're pulling photos from a person's recent camera roll, you may be using pictures that were uploaded to other sites (e.g. Google Maps), which may then cause a false positive flag for copyright violation. I would suggest including a question like "have you shared this somewhere else?", which allows people to at least give Commons a heads-up that the picture is already online.

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented Dec 8, 2016

@misaochan

This comment has been minimized.

Member

misaochan commented Dec 9, 2016

That is true. Or perhaps just state in the notification that people should be aware that if the pic has been shared to other websites, it may be copyrighted?

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented Dec 9, 2016

@misaochan

This comment has been minimized.

Member

misaochan commented May 29, 2017

I would like to include this in the IEG renewal proposal if possible. Some points of discussion:

  1. Should this be displayed whenever the user takes a photo, or when they are in the radius of a place that needs photos, or both?

  2. What should the default opt setting be? If we make it opt-in it may too obscure to find, but if it is on by default, users might get annoyed and just uninstall instead of looking for the setting to turn it off (I might have done this with one or two other apps, haha...). My suggestion would be off by default, but when user checks the Nearby list for the first time, it could ask "Would you like to be notified when you are close to a location that needs pictures? Yes/ no and never ask again". Perhaps similarly for the first time they take a picture with our app running in the background?

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented May 30, 2017

@misaochan

This comment has been minimized.

Member

misaochan commented Jun 8, 2017

Sounds viable! I just thought of another possible option - on by default, but the notification has a "turn off notifications" button.

@nemobis

This comment has been minimized.

Contributor

nemobis commented Jun 20, 2017

@misaochan

This comment has been minimized.

Member

misaochan commented Jul 6, 2017

Been looking further into this. It seems that we actually want two different types of Nearby notifications, right?

  1. Push notification (opt-in only). This will pop up if the user takes a photo while they are near a Nearby location regardless of whether or not they are in the app.

  2. In-app notification - in top panel of the proposed new UI. This just takes the nearest Nearby location and displays it to the user on the main screen. Only visible if the user has the app open.

@misaochan

This comment has been minimized.

Member

misaochan commented Jul 6, 2017

Also, for those who opt in for the push notification, do we want that to happen (1) only when the user takes a photo near a Nearby place, or (2) whenever they are very close to a Nearby location (even if they haven't taken a photo)? If we go with (2), the radius should probably be much smaller, perhaps 50m?

@nicolas-raoul nicolas-raoul changed the title from Notify about nearby Wikidata items without an image to Is this a picture of A/B/C? Is it in administrative area D/E/F? (then link Wikidata/Commons) Jul 7, 2017

@nemobis

This comment has been minimized.

Contributor

nemobis commented Aug 10, 2017

Push notification (opt-in only).

Ideally the notifications would not be opt-in; Google doesn't ask permission to trick you into contributing your resources into their proprietary database, they just pester you asking to contribute to the map. But an opt-out notification is more useful in a widely used app (like Wikipedia https://phabricator.wikimedia.org/T143884 or OsmAnd http://osmand.net/blog?id=osmand-2-7-released ) so I can understand why you want to be careful.

@misaochan

This comment has been minimized.

Member

misaochan commented Sep 3, 2017

@nemobis Sorry I missed your comment! Yeah, Google certainly doesn't ask, haha. But to be honest I've personally found Google's automatic notifications to be somewhat annoying, and I'm not sure we want to follow their "strategy" in this aspect...

@misaochan misaochan changed the title from Is this a picture of A/B/C? Is it in administrative area D/E/F? (then link Wikidata/Commons) to When user takes a photo, send push notification - "Is this a picture of A/B/C? Is it in administrative area D/E/F? (then link Wikidata/Commons)" Sep 4, 2017

@janpio

This comment has been minimized.

Contributor

janpio commented Sep 6, 2017

I reread the initial issue: Are you all sure that a notification (no matter how implemented) was the intended functionality here? I more understood that this should be a suggested location (similar to suggested categories) to be connected to the picture on upload in the Commons app.

Showing a notification the moment a picture taken (with nearby locations the picture might match) would be a different feature (and one where I am actually not sure if this is really possible).

@misaochan

This comment has been minimized.

Member

misaochan commented Sep 7, 2017

@janpio Good point. Perhaps @magnusmanske could clarify? :)

@psh psh added this to Backlog in WMCZ Plans for 2018 Sep 23, 2017

@misaochan

This comment has been minimized.

Member

misaochan commented May 7, 2018

I think going with @janpio 's interpretation for the time being would be the best way to proceed. It's much easier to implement, non-intrusive, and we can get user feedback on how helpful the feature is before considering push notifications.

My suggestion is that when the user selects an image to upload, we run an async Wikidata query in ShareActivity that searches for a place that needs pictures in a certain radius (this radius should be much smaller than the Nearby query, perhaps 100m or so). When found, we pick the closest one and display in the UI "Is this a photo of Place X"? If user says Yes, prefill title and description fields for them, and associate their upload with that Wikidata item (as if they had done a direct upload from Nearby). Appropriate category suggestions and p18 edits will follow.

There needs to also be a way for them to change their mind (perhaps a button that says "Not Place X") before submitting the upload, in case they misclicked (so we don't make a wrong p18 edit).

What do you guys think?

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented May 7, 2018

@misaochan Sounds good, but do you mean the question should pop up "when the user selects an image to upload"? That sounds disruptive, as they already have an image in mind. How about when the user opens the app, maybe? :-)

@misaochan

This comment has been minimized.

Member

misaochan commented May 7, 2018

Hmm, I meant that after the user selects the image that they want to upload, they would be brought to the Title/Desc screen as normal. The Nearby query would then run in the background for a radius of 100m, and if it finds anything, it would ask the user if this is an image of X.

The query should be relatively quick since the radius is so small, so it would likely pop up while the user is still thinking of their title/desc if my guess is correct.

@nicolas-raoul

This comment has been minimized.

Member

nicolas-raoul commented May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment