App keeps crashing on opening #3607

gupta-anmol · 2020-03-30T16:42:12Z

Summary:

App keeps crashing on opening.

Steps to reproduce:

I cloned the repo from GitHub and tried to compile it. Can't open the app now.

System logs:

2020-03-30 22:05:52.054 13692-13692/fr.free.nrw.commons.beta E/LoadedApk: Unable to instantiate appComponentFactory
    java.lang.ClassNotFoundException: Didn't find class "fr.free.nrw.commons.beta.commons" on path: DexPathList[[zip file "/system/framework/org.apache.http.legacy.boot.jar", zip file "/data/app/fr.free.nrw.commons.beta-YxpmNSMHaflmNsRTrCV_tw==/base.apk"],nativeLibraryDirectories=[/data/app/fr.free.nrw.commons.beta-YxpmNSMHaflmNsRTrCV_tw==/lib/arm64, /data/app/fr.free.nrw.commons.beta-YxpmNSMHaflmNsRTrCV_tw==/base.apk!/lib/arm64-v8a, /system/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:134)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at android.app.LoadedApk.createAppFactory(LoadedApk.java:228)
        at android.app.LoadedApk.createOrUpdateClassLoaderLocked(LoadedApk.java:733)
        at android.app.LoadedApk.getClassLoader(LoadedApk.java:812)
        at android.app.LoadedApk.getResources(LoadedApk.java:1034)
        at android.app.ContextImpl.createAppContext(ContextImpl.java:2357)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5821)
        at android.app.ActivityThread.access$1200(ActivityThread.java:200)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1673)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:201)
        at android.app.ActivityThread.main(ActivityThread.java:6810)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)

2020-03-30 23:19:13.076 28318-28375/fr.free.nrw.commons D/OkHttp: --> GET https://commons.wikimedia.org/w/api.php?format=json&formatversion=2&errorformat=plaintext&action=query&list=logevents&letype=upload&leprop=title|timestamp|ids&lelimit=500&leuser=Anmol1311
2020-03-30 23:19:13.077 28318-28318/fr.free.nrw.commons E/ContributionsFragment: onFragmentResumed fr.free.nrw.commons.contributions.ContributionsListFragment
2020-03-30 23:19:13.084 28318-28373/fr.free.nrw.commons E/AndroidRuntime: FATAL EXCEPTION: arch_disk_io_0
    Process: fr.free.nrw.commons, PID: 28318
    java.lang.RuntimeException: Exception while computing database live data.
        at androidx.room.RoomTrackingLiveData$1.run(RoomTrackingLiveData.java:92)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)
     Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.
        at androidx.room.RoomOpenHelper.checkIdentity(RoomOpenHelper.java:154)
        at androidx.room.RoomOpenHelper.onOpen(RoomOpenHelper.java:135)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onOpen(FrameworkSQLiteOpenHelper.java:142)
        at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:409)
        at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:298)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableSupportDatabase(FrameworkSQLiteOpenHelper.java:92)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.java:53)
        at androidx.room.RoomDatabase.inTransaction(RoomDatabase.java:476)
        at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.java:281)
        at androidx.room.RoomDatabase.query(RoomDatabase.java:324)
        at androidx.room.util.DBUtil.query(DBUtil.java:83)
        at fr.free.nrw.commons.contributions.ContributionDao_Impl$10.call(ContributionDao_Impl.java:666)
        at fr.free.nrw.commons.contributions.ContributionDao_Impl$10.call(ContributionDao_Impl.java:663)
        at androidx.room.RoomTrackingLiveData$1.run(RoomTrackingLiveData.java:90)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 
        at java.lang.Thread.run(Thread.java:764) 
2020-03-30 23:19:13.085 28318-28375/fr.free.nrw.commons D/CookieManager: Domain:commons.wikimedia.org
2020-03-30 23:19:13.090 28318-28373/fr.free.nrw.commons E/ACRA: ACRA caught a RuntimeException for fr.free.nrw.commons
    java.lang.RuntimeException: Exception while computing database live data.
        at androidx.room.RoomTrackingLiveData$1.run(RoomTrackingLiveData.java:92)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)
     Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.
        at androidx.room.RoomOpenHelper.checkIdentity(RoomOpenHelper.java:154)
        at androidx.room.RoomOpenHelper.onOpen(RoomOpenHelper.java:135)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onOpen(FrameworkSQLiteOpenHelper.java:142)
        at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:409)
        at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:298)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableSupportDatabase(FrameworkSQLiteOpenHelper.java:92)
        at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.java:53)
        at androidx.room.RoomDatabase.inTransaction(RoomDatabase.java:476)
        at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.java:281)
        at androidx.room.RoomDatabase.query(RoomDatabase.java:324)
        at androidx.room.util.DBUtil.query(DBUtil.java:83)
        at fr.free.nrw.commons.contributions.ContributionDao_Impl$10.call(ContributionDao_Impl.java:666)
        at fr.free.nrw.commons.contributions.ContributionDao_Impl$10.call(ContributionDao_Impl.java:663)
        at androidx.room.RoomTrackingLiveData$1.run(RoomTrackingLiveData.java:90)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 
        at java.lang.Thread.run(Thread.java:764)

Device and Android version:

Redmi Note 5 Pro
MIUI version 11
Android 9

Commons app version:

master betaDebug

The text was updated successfully, but these errors were encountered:

misaochan · 2020-03-30T17:43:32Z

Does this happen in the prod build variant?

gupta-anmol · 2020-03-30T17:51:03Z

Yes, it happens on prodDebug too.

I have added some more system logs that I missed earlier.

sivaraam · 2020-03-30T18:53:25Z

@6point022 I know this isn't a solution to the actual problem you've reported. But just try clearing the app's data and using the app. You would not experience the crash.

sivaraam · 2020-03-30T18:55:20Z

The reason for the actual problem is very clear in the error message. Quoting the relevant portion:

Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.

gupta-anmol · 2020-03-30T20:25:05Z

But just try clearing the app's data and using the app. You would not experience the crash.

@sivaraam Thanks a lot, it worked! :D

sivaraam · 2020-03-31T19:15:44Z

Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.

Let me add some information about why we're facing this issue based on the little knowledge about Room that I have.

As the error message clearly states the schema has changed without the version number being changed.

What constitutes the schema here?
For now, it's the fields of the Contribution class that are persisted.
When was it changed/Who changed it?
I suspect the crash observed here might be due to a change to the Contribution class done in PR Wiki itemname displaying in toast #3569.
Why didn't we catch this during testing?
It's complicated. In simple terms: a fresh app install wouldn't have caught the issue. As the validation would fail only when there's an existing version of the app installed and we install a new one that would introduce a schema conflict.
How do we avoid this in future?
We would have to ensure that the schema version number of is updated whenever the fields of the classes being persisted using room are changed.

Kindly correct me if I'm wrong somewhere as what I've mentioned is purely based on what I remember and it's been rusty for a while. 🙂

cc @misaochan

maskaravivek · 2020-04-02T08:58:45Z

I am also facing the same issue on fresh install. @ashishkumar468 Can this be related to your recent change?

ashishkumar468 · 2020-04-02T09:05:32Z

@maskaravivek. Not sure (None of my recent PR's have updated the schema), I will have a look, even if because of some reason, the schema was updated, it should not throw an exception on fresh installs, are you sure you faced the same on fresh installs?

maskaravivek · 2020-04-02T09:14:56Z

I just noticed that even on uninstalling the app and reinstalling the data wasn't cleared. Once I clear all app data, it works for me.

ashishkumar468 · 2020-04-02T09:16:14Z

That's weird, uninstalling should clear data.

kbhardwaj123 · 2020-04-02T09:26:33Z

@ashishkumar468 yes you are right this happened to me when I switched branch from master to 2.13-release but upon reinstalling it got fixed

ashishkumar468 · 2020-04-02T09:29:49Z

Yes, one of the PR' must-have updated the schema. Should not be an issue though, because since room has been added, no releases have been made. So for end-user, this won't make a difference, although we should add migrations whenever a schema update is done.

misaochan · 2020-04-06T10:11:56Z

Ah, okay. I can remove this from the release list then, but we would need to make sure that this doesn't happen again in the future (because then it will impact end users).

misaochan · 2020-04-08T16:37:44Z

I just noticed that even on uninstalling the app and reinstalling the data wasn't cleared. Once I clear all app data, it works for me.

The same thing happened for me. Uninstalling and reinstalling didn't work, only clearing app data manually via Settings worked.

macgills · 2020-04-09T07:10:34Z

are ye running gradlew uA (or uninstallAll if you write out full gradle commands)? I would hazard the issue is uninstalling beta and not prod or vice versa. I have never run into this issue.

There should be no AppData to clear if it is fully uninstalled

misaochan · 2020-04-09T16:35:59Z

Oh, right! Yes, I had beta installed, whoops.

macgills · 2020-04-10T09:24:19Z

Is there something here to do or can we close this?

misaochan · 2020-04-11T13:47:54Z

I would like to discuss if there is a way to ensure that this doesn't happen again in the future - we were lucky that Room was implemented post the last release, but if we weren't then this would be impacting end users. Is there a process that we can implement that must be followed for schema updates, perhaps?

macgills · 2020-04-13T10:20:49Z

There are 2 camps for this, or at least 2 that I have followed

Every change to the database write a migration
Every release write a migration at the end

At release time testing that we can update from a previous version should be done regardless because you need to test your migration code.

I favour 2 though it does require some ownership of that code from someone at release time.

1 can be a bit hard to catch I find especially since so many people could add/remove/rename a field on a model and not see that that has an effect on the database.

Regardless we should all be following the advice of Barty Crouch pretending to be Mad Eye Moody, constant vigilance!

sivaraam · 2020-04-13T18:00:00Z

Option 2 sounds good if we are confident we won't miss that before release (else we get a lot of angry users!).

I'm just wondering about one other thing though. AFAIK, we frequently publish alpha versions to play store. If we push the migration to just before release those intermediate alpha updates would result in a crash (if the schema is changed, of course), wouldn't it? Would that be fine as it's just the alpha version?

maskaravivek · 2020-04-13T20:11:10Z

I'm just wondering about one other thing though. AFAIK, we frequently publish alpha versions to play store. If we push the migration to just before release those intermediate alpha updates would result in a crash (if the schema is changed, of course), wouldn't it?

yes, right. the app will crash for them.

I guess we should go with option 1 as on every commit to master an alpha release is made.

Also, from a maintenance standpoint, it might be easier to have migrations for every change.

macgills · 2020-04-14T08:15:32Z

It is that or communicate to alpha users that they will need a fresh install on some versions, alphas are never renowned for their stability.

The thing I don't like about option 1 is how much extra code it adds but it is the "safer" option and causes less friction for our alpha users

misaochan · 2020-04-20T17:48:36Z

I would be in favour of option 1 as well. While I'm sure our alpha testers will understand, we would still want to reduce the number of crashes that they encounter, if only because we will have to sift through all of the crash reports to find the "real" reports in the sea of "schema update" reports.

As you guys have said, it is safer as well and there is clear code ownership.

macgills · 2020-04-21T07:47:41Z

There is 1 more alternative if we don't particularly care about migrating our data between app versions

.fallbackToDestructiveMigration()

It isn't great but as long as we keep increasing the schema number there are no crashes. There is no data retention between versions though.

We could run a hybrid of option 2 and this, I am pretty sure a Migration can be to any arbitrary greater integer eg our first app version launches with v1 and the next app version launches with v100, we only have 1 migration 1->100

maskaravivek · 2020-04-21T09:21:59Z

.fallbackToDestructiveMigration()

Having this in place sounds good to me. With this in place, we could do proper migrations just for beta/prod releases.

ashishkumar468 · 2020-10-12T03:14:22Z

.fallbackToDestructiveMigration()

Having this in place sounds good to me. With this in place, we could do proper migrations just for beta/prod releases.

The discussed solution has already been implemented on the current master. Closing this issue, feel free to re-open if the issues comes up again.

Gunin2001 · 2021-05-21T19:38:49Z

I am facing the same issue but fallbackToDestructiveMigration() is not working. Whenever I upload data from database to my recyclerView it crashes
Is there a way to solve this by adding any dependancy or changing version number as the error suggests

(PS I'm. a beginner so I don't really know that much and desperately need help )

Gunin2001 · 2021-05-21T19:43:53Z

The reason for the actual problem is very clear in the error message. Quoting the relevant portion:

Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.

how to change this version number ??

sivaraam · 2021-05-24T17:47:51Z

@Gunin2001 IIUC, updating the version number shouldn't be necessary if fallbackToDestructiveMigration works properly. Where do you face this issue?

sivaraam · 2021-05-31T18:05:17Z

I just happened to face the Room crash myself when upgrading from 3.0.0.1003~7db6f83 to 3.0.0.1007~4fa18e5. So, re-opening this issue.

I sent the log of that crash to the private crash list.

Gunin2001 · 2021-05-31T18:11:18Z

what finally worked for me was

clearing app data and removing cache on the safe side
changing the version number of the room db in the Database class
3)Using fallbackToDestructiveMigration
4)Reinstalling the app

PS:- I don't know if a specific thing works . So, I mentioned all the steps it took me to clear the error

sivaraam · 2021-05-31T18:15:53Z

Thanks @Gunin2001 ! For me clearing the data of the app alone works reliably :)

The issue is it was made unnecessary. It's not clear why it has become necessary again.

Gunin2001 · 2021-05-31T18:17:21Z

Yeah, a lot of programmers on stackoverflow also said that it works for them as well, but I was stuck on that for days and all these steps helped me out.
Happy coding 👍

misaochan · 2021-06-03T10:43:10Z

This seems to be the same with the crash at #4435 . So it seems that we just need to upgrade the version number before we release to Google Play.

Rishavgupta12345 · 2022-03-01T06:33:12Z

@nicolas-raoul This issue is pretty old and the app does not crash now , it works fine so we can safely close this issue

misaochan added bug high priority labels Apr 2, 2020

misaochan mentioned this issue Apr 2, 2020

Items needed for v2.13 #3334

Closed

30 tasks

misaochan mentioned this issue Apr 20, 2020

#3222 Merge Structured Data branch into master #3553

Merged

3 tasks

ashishkumar468 closed this as completed Oct 12, 2020

sivaraam reopened this May 31, 2021

misaochan mentioned this issue Jun 3, 2021

Handle migration to prevent crash on start #4435

Closed

nicolas-raoul closed this as completed Mar 1, 2022

Rishavgupta12345 mentioned this issue Mar 11, 2022

Clear the old issues in this repository #4887

Open

App keeps crashing on opening #3607

App keeps crashing on opening #3607

Comments

gupta-anmol commented Mar 30, 2020 • edited

misaochan commented Mar 30, 2020

gupta-anmol commented Mar 30, 2020

sivaraam commented Mar 30, 2020

sivaraam commented Mar 30, 2020

gupta-anmol commented Mar 30, 2020

sivaraam commented Mar 31, 2020

maskaravivek commented Apr 2, 2020

ashishkumar468 commented Apr 2, 2020

maskaravivek commented Apr 2, 2020

ashishkumar468 commented Apr 2, 2020

kbhardwaj123 commented Apr 2, 2020

ashishkumar468 commented Apr 2, 2020

misaochan commented Apr 6, 2020

misaochan commented Apr 8, 2020

macgills commented Apr 9, 2020

misaochan commented Apr 9, 2020

macgills commented Apr 10, 2020

misaochan commented Apr 11, 2020

macgills commented Apr 13, 2020

sivaraam commented Apr 13, 2020

maskaravivek commented Apr 13, 2020

macgills commented Apr 14, 2020

misaochan commented Apr 20, 2020

macgills commented Apr 21, 2020 • edited

maskaravivek commented Apr 21, 2020

ashishkumar468 commented Oct 12, 2020

Gunin2001 commented May 21, 2021

Gunin2001 commented May 21, 2021

sivaraam commented May 24, 2021

sivaraam commented May 31, 2021 • edited

Gunin2001 commented May 31, 2021

sivaraam commented May 31, 2021 • edited

Gunin2001 commented May 31, 2021

misaochan commented Jun 3, 2021

Rishavgupta12345 commented Mar 1, 2022

gupta-anmol commented Mar 30, 2020 •

edited

macgills commented Apr 21, 2020 •

edited

sivaraam commented May 31, 2021 •

edited

sivaraam commented May 31, 2021 •

edited