[Bug]: Use of "previous" then "next" causes duplicates if name changed

[pigsonthewing]

Summary

When uploading multiple images, switching backwards and forwards between them to edit the "caption" [sic: file name] causes duplicate uploads

Steps to reproduce

1. Select multiple images to share
2. Share to app
3. Enter caption and description for first image
4. Copy details to all images
5. Select "Next"
6. Modify image caption
7. Select "Previous"
8. Modify image caption
9. Select "Next"
10. Select "Next" again
11. Optionally repeat 6-9
12. Complete upload

Expected behaviour

Each image should be uploaded once, with the final version of its caption as the file name.

Actual behaviour

Multiple copies of images are uploaded.

Device name

Nord Plus One

Android version

Android 11

Commons app version

3.1.1~1c9267ca0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

[nicolas-raoul]

Thanks for reporting!

Good news, that does not seem to happen in recent master, I just tried with the exact same steps. If this is actually not happening every time, please let us know, thanks! 🙂

[pigsonthewing]

If this is actually not happening every time, please let us know

Happy to test; when will this master be deployed?

[nicolas-raoul]

Happy to test; when will this master be deployed?

Thanks a lot, that's a great help!
I believe it is already available to beta users. Here is how to join the beta: https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#testers

[pigsonthewing]

I have now tested this using the current Beta (version=4.0.3~23c474b06). The issue persists, and occurred on my first attempt to upload multiple images..

See screenshot at https://commons.wikimedia.org/wiki/File:Commons_app_beta_screenshot_showing_duplicate_uploads_-_2022-08-07.png (The duplicate copies have been nominated for speedy deletion.)

Another screenshot - https://commons.wikimedia.org/wiki/File:Commons_app_beta_screenshot_showing_duplicate_uploads_-_2022-08-07_-_02.jpg - shows the app itself, with two images having identical file names.

[nicolas-raoul]

Thanks, I will try again!

…

On Sun, 7 Aug 2022, 18:37 Andy Mabbett, ***@***.***> wrote: I have now tested this using the current Beta (version=4.0.3~23c474b06). The issue persists, and occurred on my first attempt to upload multiple images.. See screenshot at https://commons.wikimedia.org/wiki/File:Commons_app_beta_screenshot_showing_duplicate_uploads_-_2022-08-07.png (The duplicate copies have been nominated for speedy deletion.) — Reply to this email directly, view it on GitHub <#4966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYKBRM2GWYU6JWMOCOVE3VX57XLANCNFSM5WSEIWNA> . You are receiving this because you commented.Message ID: ***@***.***>

[ShashwatKedia]

@nicolas-raoul I tested with the steps provided, [Screencast] but the app correctly uploaded the images without any duplicates. @pigsonthewing does this issue still occur for you? If not, could we close the issue?

[pigsonthewing]

Seems fixed; thank you