Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in ShareActivity.java #636

Closed
misaochan opened this issue May 19, 2017 · 7 comments
Closed

Fix memory leak in ShareActivity.java #636

misaochan opened this issue May 19, 2017 · 7 comments
Assignees
Labels

Comments

@misaochan
Copy link
Member

No description provided.

@misaochan misaochan added the bug label May 19, 2017
@sandarumk
Copy link
Collaborator

screenshot_1495209932

@misaochan
Copy link
Member Author

@dbrant has explained that this is due to the activity context being passed into GpsExtractor. java on initiation. We should pass the application context instead if possible, or pass the context directly into the methods that need it.

@misaochan
Copy link
Member Author

Has this been fixed by the recent patch?

@maskaravivek
Copy link
Member

I didn't notice any leaks while uploading a couple of images. It would be great if others could help in testing this. @misaochan @neslihanturan need your help in testing it. :)

@misaochan
Copy link
Member Author

I tested (on a real device running 7.0) and don't get these leaks either, we'll see if @neslihanturan does.

@neslihanturan
Copy link
Collaborator

Tested on a real device 4.2.4, and no leak occurred.

@maskaravivek
Copy link
Member

Closing the issue then. ShareActivity has undergone a lot of changes since the issue was reported. It might have got fixed in the process.

@maskaravivek maskaravivek moved this from Backlog to Done in IEG renewal 2017 Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants