Addition: Pull down to refresh in nearby activity #1164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
=========================================
- Coverage 3.96% 3.95% -0.01%
=========================================
Files 123 123
Lines 5604 5610 +6
Branches 542 542
=========================================
Hits 222 222
- Misses 5367 5373 +6
Partials 15 15
Continue to review full report at Codecov.
|
maskaravivek
left a comment
maskaravivek
left a comment
There was a problem hiding this comment.
Please address these comments.
Good to merge once the comments are addressed and the changes are tested. :)
| android:layout_height="wrap_content" /> | ||
|
|
||
| <android.support.v4.widget.SwipeRefreshLayout | ||
|
|
| bundle = new Bundle(); | ||
| initDrawer(); | ||
| initViewState(); | ||
| swipeLayout=(SwipeRefreshLayout)findViewById(R.id.swipe_container); |
There was a problem hiding this comment.
use butterknife.
|
Sure. I will make the changes and commit ASAP. |
|
Please review the changes |
|
@97balakrishnan Swipe to refresh works fine. The list updates even if the location has not changed. @misaochan @neslihanturan Is that behaviour fine. If yes, we can go ahead and merge this. Have tested it on a real device. |
|
I just noticed that it exactly replicates the functionality of the refresh button. Going ahead and merging it. @97balakrishnan congrats for your first contribution. :) |
|
Thanks a lot. My pleasure. I'll make the changes to prevent it from refreshing if the locations not changed ASAP. Thanks again |
4 participants
PR for #264
Pull down to refresh feature added in nearby activity.
SwipeRefreshLayout used