New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ItemDivider in NotificationActivity #1193

Merged
merged 2 commits into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@ayushin78
Contributor

ayushin78 commented Feb 24, 2018

Description

Fixes #1186

Added ItemDivider in NotificationActivity using DividerItemDecoration

Screenshots showing what changed

Before

1

After

2

ayushin78 added some commits Feb 24, 2018

Add ItemDivider in NotificationActivity (#1186)
* Use DividerItemDecoration to add ItemDivider in RecycleView
Remove View Bindings in NotificationActivity
* ButterKnife already used
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 24, 2018

Codecov Report

Merging #1193 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1193      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5798    5799       +1     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5561    5562       +1     
  Partials       15      15
Impacted Files Coverage Δ
...nrw/commons/notification/NotificationActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2b51...ccf68d1. Read the comment docs.

codecov-io commented Feb 24, 2018

Codecov Report

Merging #1193 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1193      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5798    5799       +1     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5561    5562       +1     
  Partials       15      15
Impacted Files Coverage Δ
...nrw/commons/notification/NotificationActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2b51...ccf68d1. Read the comment docs.

@maskaravivek

This comment has been minimized.

Show comment
Hide comment
@maskaravivek

maskaravivek Feb 24, 2018

Member

Looks good to me. Will wait for @neslihanturan, our UI expert ;) to take a look before me merge it.

Member

maskaravivek commented Feb 24, 2018

Looks good to me. Will wait for @neslihanturan, our UI expert ;) to take a look before me merge it.

@misaochan

This comment has been minimized.

Show comment
Hide comment
@misaochan

misaochan Feb 25, 2018

Member

Thanks for the PR @ayushin78 ! Looks good to me, too. :)

Member

misaochan commented Feb 25, 2018

Thanks for the PR @ayushin78 ! Looks good to me, too. :)

@maskaravivek

This comment has been minimized.

Show comment
Hide comment
@maskaravivek

maskaravivek Feb 26, 2018

Member

Have tested on a real device. Works fine.

Going ahead and merging it. :)

Member

maskaravivek commented Feb 26, 2018

Have tested on a real device. Works fine.

Going ahead and merging it. :)

@maskaravivek maskaravivek merged commit 88a4e50 into commons-app:master Feb 26, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maskaravivek maskaravivek referenced this pull request Feb 26, 2018

Closed

Fixes #1205 #1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment