New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Rate Us Feature from AboutActivity #1264

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
4 participants
@ayushin78
Contributor

ayushin78 commented Mar 6, 2018

Description

Rate us feature is added in Utils, But it is never used/launched. Also, The rate us feature is not working for the debug build type.

  • Add LaunchRatings Method in AboutActivity (Fixes #1263 )
  • Fix Package Name to enable rate us feature in debug build type

Screenshots

Before After
screenshot_2018-03-06-21-21-20-93 screenshot_2018-03-06-21-21-14-91
Launch Rate Us Feature from AboutActivity
Rate us feature is added in Utils, But it is never used/launched.

* Add LaunchRatings Method in AboutActivity
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 6, 2018

Codecov Report

Merging #1264 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1264      +/-   ##
=========================================
- Coverage    3.78%   3.78%   -0.01%     
=========================================
  Files         125     125              
  Lines        5866    5868       +2     
  Branches      578     578              
=========================================
  Hits          222     222              
- Misses       5629    5631       +2     
  Partials       15      15
Impacted Files Coverage Δ
app/src/main/java/fr/free/nrw/commons/Utils.java 26.31% <0%> (ø) ⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51221f6...b6c2de8. Read the comment docs.

codecov-io commented Mar 6, 2018

Codecov Report

Merging #1264 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1264      +/-   ##
=========================================
- Coverage    3.78%   3.78%   -0.01%     
=========================================
  Files         125     125              
  Lines        5866    5868       +2     
  Branches      578     578              
=========================================
  Hits          222     222              
- Misses       5629    5631       +2     
  Partials       15      15
Impacted Files Coverage Δ
app/src/main/java/fr/free/nrw/commons/Utils.java 26.31% <0%> (ø) ⬆️
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51221f6...b6c2de8. Read the comment docs.

Fix Package Name to enable rate us feature
The rate us feature was not working for the debug build type since getPackageName() was returning the fr.free.nrw.commons.debug. Use of this package name was leading to an error on google play.

* Replace getPackageName() with BuildConfig.class.getPackage().getName() in rateApp method of Utils.java
@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Mar 6, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/fr/free/nrw/commons/Utils.java  1
         

See the complete overview on Codacy

codacy-bot commented Mar 6, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/fr/free/nrw/commons/Utils.java  1
         

See the complete overview on Codacy

@commons-app commons-app deleted a comment from codacy-bot Mar 6, 2018

@maskaravivek

This comment has been minimized.

Show comment
Hide comment
@maskaravivek

maskaravivek Mar 7, 2018

Member

Tested on a real device. Works perfectly. Thanks @ayushin78

Member

maskaravivek commented Mar 7, 2018

Tested on a real device. Works perfectly. Thanks @ayushin78

@maskaravivek maskaravivek merged commit cfc1449 into commons-app:master Mar 7, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment