Added Wikitalk Page #5740

kanahia1 · 2024-05-23T14:47:50Z

Description (required)

Fixes #2425

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Progress

Improved BottomSheet in the Nearby for the Lanscape Mode

Screen_Recording_20240523_161256_Commons.mp4

Added Wikitalk page

Keeping this PR as draft until I am able to solve the problem for creating/editing page.

nicolas-raoul · 2024-05-24T00:23:43Z

The UI looks good to me so far. 🙂

kanahia1 · 2024-05-30T08:08:00Z

Finally I am successful in creating pages

https://commons.m.wikimedia.org/wiki/Talk:Q65994945

Since we can also add subject, Should we also add option for the subject? Currently I am taking only description as input (e.g This is demo text) and subject is hardcoded (e.g For Testing Purpose)

nicolas-raoul · 2024-05-30T08:34:59Z

For the title I would suggest a hard-coded English-language-only ==Please fix this item==.

The body of the message could be something like:

Someone using the [[Commons:Mobile_app|Commons Android app]] went to this item's geographical location (123.43124,98.97789) and noted the following problem(s):
* <nowiki>_Is at a different place._</nowiki>

Details: <nowiki>_It has moved to across the street blabla._</nowiki>

Please anyone fix the item accordingly, then reply to mark this section as fixed. Thanks a lot for your cooperation!

~~~~

Indicating the current location of the item is useful because it may change in the future, making it difficult to understand what is being talked about (for instance what is the initial side of the street).

kanahia1 · 2024-05-31T07:19:11Z

Hello @nicolas-raoul, I have successfully created the wikitalk page and here is design I have came up with for the page https://commons.m.wikimedia.org/wiki/Talk:Q73763141 (created/edited using the app)

I am looking for more suggestions for the design

nicolas-raoul · 2024-05-31T07:58:20Z

Sorry my mistake please put the italics outside of the nowiki tags not inside.

The tildes signature was not recognized it seems. Not a big issue.

nicolas-raoul · 2024-05-31T08:09:47Z

Would you mind posting a screencast showing the whole use of the feature as implemented now?

kanahia1 · 2024-05-31T08:21:34Z

I have fixed the italics and here's video for editing/creating

WhatsApp.Video.2024-05-31.at.13.49.07_e50e0d57.mp4

nicolas-raoul · 2024-05-31T11:33:45Z

I think that checkboxes like in the issue description would lead to more helpful feedback:

Write something about the "GS1 Japan" item. It will be publicly visible. 

☐ "GS1 Japan" does not exist anymore, no picture can ever be taken of it. 
☑ "GS1 Japan" is at a different place (please specify the correct place below, if possible tell us the correct latitude/longitude). 
☐ Other problem or information (please explain below).

 --------------------------------------------------------------
 blabla
 --------------------------------------------------------------

Current talk page content would come after this.
Actually, showing talk page content in the app itself is not required (and impossible to do perfectly due to complex wikicode such as transclusions), a web link to the talk page is enough. 🙂

nicolas-raoul · 2024-05-31T11:37:31Z

The section posted to the talk page would include the English text for each selected checkbox, plus the comment if there is one.

kanahia1 · 2024-05-31T11:42:56Z

Got it 😄 Will share the commit asap

kanahia1 · 2024-06-01T02:41:27Z

Hello @nicolas-raoul, I have implemented new page. And here's video demonstration

WhatsApp.Video.2024-06-01.at.08.10.31_1a8189df.mp4

nicolas-raoul · 2024-06-01T03:38:55Z

Looks great!
I am getting a crash though, screencast on Zulip.

nicolas-raoul · 2024-06-01T05:09:19Z

Great but I noticed an issue: The server to edit is Wikidata server, not Commons server. 🙂

nicolas-raoul · 2024-06-01T05:13:33Z

For instance, your Abaspura edit should be made here:
https://www.wikidata.org/w/index.php?title=Talk:Q4663549&action=edit&redlink=1
not at https://commons.wikimedia.org/wiki/Talk:Q4663549 which is not the talk page of a real item or anything on that wiki.

RitikaPahwa4444

Nice! The last option, that is, "Other problem or information (please explain below)" has an edit text field but I'm able to send the talk without any comment. How about making it mandatory?

nicolas-raoul · 2024-06-01T06:36:59Z

+1 on making the text field mandatory if the third checkbox is enabled.

By the way, it looks like a bookmark is set to any item I open the dialog for. Is that intended? Screencast on Zulip.

kanahia1 · 2024-06-01T07:27:29Z

Also I have changed the url now the edit is made a wikidata url 🎉
https://m.wikidata.org/wiki/Talk:Q16640641

nicolas-raoul · 2024-06-03T05:52:34Z

Working great, thanks! https://www.wikidata.org/wiki/Talk:Q65225721
How about coming back after the Wikidata edit is made, rather than staying on the "Write something about the [...] item" activity? Otherwise people may not see the toast, and post twice.

nicolas-raoul

Great work, a bit of polishing still needed before merging. :-)

nicolas-raoul · 2024-06-03T05:53:00Z

app/src/main/AndroidManifest.xml

+      android:required="false" />
+  </application>
+
+</manifest>


Is this change required?

app/src/main/java/fr/free/nrw/commons/actions/PageEditClient.kt

app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java

nicolas-raoul · 2024-06-03T05:54:19Z

app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java

@@ -230,6 +247,14 @@ public PageEditClient provideCommonsPageEditClient(@Named(NAMED_COMMONS_CSRF) Cs
        return new PageEditClient(csrfTokenClient, pageEditInterface);
    }

+    @Named("wikidata-page-edit")


app/src/main/java/fr/free/nrw/commons/nearby/PageEditHelper.java

app/src/main/java/fr/free/nrw/commons/nearby/WikidataFeedback.kt

nicolas-raoul · 2024-06-03T05:57:59Z

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java

@@ -674,26 +681,40 @@ private void initBottomSheets() {
        bottomSheetListBehavior.setState(BottomSheetBehavior.STATE_HIDDEN);
    }

+    private int getSpanCount() {


nicolas-raoul · 2024-06-03T06:00:14Z

app/src/main/res/values/strings.xml

@@ -818,4 +818,6 @@ Upload your first media by tapping on the add button.</string>
  </plurals>
  <string name="multiple_files_depiction">Please remember that all images in a multi-upload get the same categories and depictions. If the images do not share depictions and categories, please perform several separate uploads.</string>
  <string name="multiple_files_depiction_header">Note about multi-uploads</string>
+  <string name="nearby_wikitalk">wikitalk</string>


This is the tooltip right? How about "Report a problem about this item to Wikidata"?

kanahia1 · 2024-07-08T01:32:17Z

@nicolas-raoul, I am sorry 😞 I totally forgot about the reviews. I have made all the suggested changes in the newer commit c0b2fc7

nicolas-raoul

Fantastic, thanks a lot for taking care of this! 🙂

Added wikitalk page and improved bottomsheet for landscape mode

5f8592e

Improved wikitalk page

ace104d

kanahia1 marked this pull request as ready for review May 31, 2024 07:16

Fixed italics

5590f47

Fixed little bug

132b2c1

Improved the wiki talk page

8d28406

Merge branch 'main' into issue2425

8081090

.

156922f

changed commons url to wikidata url

5101260

RitikaPahwa4444 reviewed Jun 1, 2024

View reviewed changes

kanahia1 added 2 commits June 1, 2024 12:12

changed commons url to wikidata url + 1

d326f64

fixed bookmark issue

ade49d2

Merge branch 'main' into issue2425

18acd07

nicolas-raoul requested changes Jun 3, 2024

View reviewed changes

kanahia1 and others added 3 commits July 7, 2024 08:28

Added kdoc and javadoc

c0b2fc7

Merge remote-tracking branch 'origin/issue2425' into issue2425

16df5e0

Merge branch 'main' into issue2425

8292d13

nicolas-raoul approved these changes Jul 8, 2024

View reviewed changes

nicolas-raoul merged commit 3779cfb into commons-app:main Jul 8, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Wikitalk Page #5740

Added Wikitalk Page #5740

kanahia1 commented May 23, 2024

nicolas-raoul commented May 24, 2024

kanahia1 commented May 30, 2024

nicolas-raoul commented May 30, 2024

kanahia1 commented May 31, 2024

nicolas-raoul commented May 31, 2024

nicolas-raoul commented May 31, 2024

kanahia1 commented May 31, 2024

nicolas-raoul commented May 31, 2024

nicolas-raoul commented May 31, 2024

kanahia1 commented May 31, 2024

kanahia1 commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

RitikaPahwa4444 left a comment

nicolas-raoul commented Jun 1, 2024

kanahia1 commented Jun 1, 2024

nicolas-raoul commented Jun 3, 2024

nicolas-raoul left a comment

nicolas-raoul Jun 3, 2024

nicolas-raoul Jun 3, 2024

nicolas-raoul Jun 3, 2024

nicolas-raoul Jun 3, 2024

kanahia1 commented Jul 8, 2024 •

edited

Loading

nicolas-raoul left a comment

Added Wikitalk Page #5740

Added Wikitalk Page #5740

Conversation

kanahia1 commented May 23, 2024

nicolas-raoul commented May 24, 2024

kanahia1 commented May 30, 2024

nicolas-raoul commented May 30, 2024

kanahia1 commented May 31, 2024

nicolas-raoul commented May 31, 2024

nicolas-raoul commented May 31, 2024

kanahia1 commented May 31, 2024

nicolas-raoul commented May 31, 2024

nicolas-raoul commented May 31, 2024

kanahia1 commented May 31, 2024

kanahia1 commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

nicolas-raoul commented Jun 1, 2024

RitikaPahwa4444 left a comment

Choose a reason for hiding this comment

nicolas-raoul commented Jun 1, 2024

kanahia1 commented Jun 1, 2024

nicolas-raoul commented Jun 3, 2024

nicolas-raoul left a comment

Choose a reason for hiding this comment

nicolas-raoul Jun 3, 2024

Choose a reason for hiding this comment

nicolas-raoul Jun 3, 2024

Choose a reason for hiding this comment

nicolas-raoul Jun 3, 2024

Choose a reason for hiding this comment

nicolas-raoul Jun 3, 2024

Choose a reason for hiding this comment

kanahia1 commented Jul 8, 2024 • edited Loading

nicolas-raoul left a comment

Choose a reason for hiding this comment

kanahia1 commented Jul 8, 2024 •

edited

Loading