Do not require QWidget in decorator generated by ctkWrapPythonQt #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including QObject is sufficient, this was an oversight of the initial implementation added in d3f81f4 (Move all PythonQt wrapping code into one script. See commontk#449) Inspired-by: Eric Heim <e.heim@dkfz-heidelberg.de>
jcfr
added a commit
that referenced
this pull request
Apr 30, 2015
Do not require QWidget in decorator generated by ctkWrapPythonQt
|
@eric-h Since I omitted the commit jcfr@b533dc8 originally referenced in my first version of For reference, see also #538 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including QObject is sufficient, this was an oversight of the initial
implementation added in d3f81f4 (Move all PythonQt wrapping code into
one script. See #449)
Inspired-by: Eric Heim e.heim@dkfz-heidelberg.de