Treat the absence of additionalProperties similarly to false. #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSONSchema defaults this to true, but we want an intermediate behavior where if it's missing, we don't traverse the property, but we also don't reject the object as invalid.
seefeldb
approved these changes
Jul 31, 2025
| // don't invalidate the object, but also don't descend down | ||
| // into that property. | ||
| if (propSchema === undefined) { | ||
| filteredObj[propKey] = propValue; |
Contributor
There was a problem hiding this comment.
Should we even assign it? It shouldn't be sent to an untrusted function (i.e. CFC will base it's decision on the assumption it isn't sent)
Contributor
Author
There was a problem hiding this comment.
For the current use cases, this lets you have a required property that's in the additionalProperties.
The returned object isn't actually used right now, so it's not a CFC issue (we will return the entire doc for each doc we use). If we do want to prevent it from being included, we can also specify additionalProperties false.
However, when evaluating this to determine whether we can access a field, it might be best to prevent reads/writes. I'll keep this in mind when I tackle that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONSchema defaults this to true, but we want an intermediate behavior where if it's missing, we don't traverse the property, but we also don't reject the object as invalid.
The
{}value is still treated as a true schema, and will traverse the property values.Summary by cubic
Changed how missing additionalProperties in JSONSchema is handled. Now, if additionalProperties is not set, we skip traversing unknown properties but do not mark the object as invalid.