Add a quicklaunch toolbar to spawn new charms to the space default charm #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toolshed patterns endpoint
jsantell
approved these changes
Sep 15, 2025
|
|
||
| try { | ||
| // Security: validate filename doesn't contain path traversal | ||
| if (filename.includes("..") || filename.includes("/")) { |
| const url = new URL(filename, this.baseUrl); | ||
|
|
||
| try { | ||
| return await Deno.readFile(url); |
Collaborator
There was a problem hiding this comment.
Maybe we want to cache this somewhere so that we don't have to hit the disk as often, potential followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpProgramResolverand the patterns api endpoint, instead of the static cacheSummary by cubic
Adds a Quicklaunch toolbar to the default space charm and serves the default app via a new Toolshed patterns API, replacing the old static recipe. This makes spawning common charms one click and decouples Shell from bundled assets.
New Features
Refactors