Skip to content

Conversation

@jsantell
Copy link
Collaborator

@jsantell jsantell commented Nov 26, 2025

Summary by cubic

Shows the Home space when visiting the root path by introducing a builtin "home" view and loading its pattern. Centralizes builtin pattern creation with a new factory and removes the old default-pattern helper.

  • New Features

    • Added builtin "home" view; AppView loads or creates the Home charm.
    • Runtime supports "builtin" views and initializes a session for home.
  • Refactors

    • Replaced default-pattern.ts with pattern-factory.ts supporting "home" and "space-default".
    • BodyView uses the factory for the default space pattern; RootView defaults to { builtin: "home" }.

Written for commit f612887. Summary will update automatically on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/shell/src/views/AppView.ts">

<violation number="1" location="packages/shell/src/views/AppView.ts:140">
Call `await rt.cc().manager().synced()` before scanning `getAllCharms()`; otherwise the charms list may still be empty and this block will recreate the home pattern unnecessarily every time the shell loads.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@jsantell jsantell merged commit a831098 into main Nov 26, 2025
9 checks passed
@jsantell jsantell deleted the add-home-space branch November 26, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants