Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark themes in terminal #380

Closed
romankrv opened this issue Jul 22, 2015 · 15 comments
Closed

Dark themes in terminal #380

romankrv opened this issue Jul 22, 2015 · 15 comments
Labels

Comments

@romankrv
Copy link

Need redesign color in dark themes in terminal.
It's look like this. See attach
screen shot 2015-07-22 at 1 01 40 pm

@dgutov
Copy link
Member

dgutov commented Jul 23, 2015

I suppose; patches welcome.

But does Emacs even know that it's running in a dark-background terminal? The popup looks much better on a light background.

@romankrv
Copy link
Author

It's problem on iTerm. It's probably conflict 256 color of the palette of iTerm and company.el color palette.

@dgutov
Copy link
Member

dgutov commented Jul 23, 2015

256 color

Right.

But what I mean is, you might not be able to just change the colors to look better on dark background. What does frame-background-mode evaluate to, in the above environment?

@romankrv
Copy link
Author

Can you get me more detail or workflow how to deal with the “frame-background-mode“
M-x frame-background-mode not much in my emacs

@dgutov
Copy link
Member

dgutov commented Jul 23, 2015

M-: frame-background-mode RET

@romankrv
Copy link
Author

not exist, can give me elisp code for that?

@dgutov
Copy link
Member

dgutov commented Jul 23, 2015

What does not exist? This variable has been in Emacs for years.

What kind of code are you looking for?

@romankrv
Copy link
Author

I try to find function as you said: frame-background-mode
but it only has - frame-set-background-mode

screen shot 2015-07-24 at 5 45 32 pm

How to get frame-background-mode ?
Thanks

@Silex
Copy link

Silex commented Jul 24, 2015

It's a variable.

@romankrv
Copy link
Author

screen shot 2015-07-24 at 6 13 45 pm
Yes, you are right, it exist.
This variable has value 'nil' I checked it in iTerm(256 color app) and Term.app (16 color app) and both of them are equal 'nul'
That is it variable not use in.

Tell me please, Is your project (company-mode) not ready to work with 256 color palette?

Let's start to plan to change it. You agree? Because you are more the expert in your project then I.

Thanks.

@dgutov
Copy link
Member

dgutov commented Jul 24, 2015

@romankrv Does anything change, visually, if you customize that variable to dark?

@romankrv
Copy link
Author

okay, I try it
and report then

@dgutov dgutov closed this as completed Jan 11, 2016
@ned2
Copy link

ned2 commented Feb 12, 2016

Leaving a comment here for those like me coming from a Google search for this problem. For me, the solution was changing my TERM environment variable from one that does not have full 256 bit color support (in my case it was set to screen) to one that does, like xterm-256color or screen-256color if using screen.

@dgutov
Copy link
Member

dgutov commented Feb 12, 2016

@ned2 Thanks!

@ghost
Copy link

ghost commented Jun 20, 2017

for someone find the answer, may you can try to add these code below:

(custom-set-faces
 '(company-preview
   ((t (:foreground "darkgray" :underline t))))
 '(company-preview-common
   ((t (:inherit company-preview))))
 '(company-tooltip
   ((t (:background "lightgray" :foreground "black"))))
 '(company-tooltip-selection
   ((t (:background "steelblue" :foreground "white"))))
 '(company-tooltip-common
   ((((type x)) (:inherit company-tooltip :weight bold))
    (t (:inherit company-tooltip))))
 '(company-tooltip-common-selection
   ((((type x)) (:inherit company-tooltip-selection :weight bold))
    (t (:inherit company-tooltip-selection)))))

link is here: https://github.com/nsf/gocode/tree/master/emacs-company

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants