Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

.dir-locals.el in 0.6.1 package causes prompt at install time #4

Closed
purcell opened this Issue · 9 comments

3 participants

Steve Purcell Nikolaj Schumacher Dmitry Gutov
Steve Purcell

When installing 0.6.1 (but not 0.6), Emacs prompts the user to confirm the safety of the local variables set in ~/.emacs.d/elpa/company-0.6.1 -- I guess this is because the .dir-locals.el is included in the package.

Nikolaj Schumacher
Owner

.dir-locals.el itself is fine. But specifically the variable emacs-lisp-docstring-fill-column isn't considered "safe" by Emacs.

Dmitry Gutov
Owner

Um, yes. emacs-lisp-docstring-fill-column is not safe, probably due to oversight.

I'll try to find out of we can exclude .dir-locals.el from packaging while keeping it in the repository.

Dmitry Gutov
Owner

@purcell
To be sure, I made this variable unsafe again on the local machine and tried to download the package.

It installed and turned on fine, the prompt only shows up when you try to open one of the files. Is that accurate?

Steve Purcell

Nope. If I delete the company-0.6.1 directory and restart Emacs, configured such that it automatically package-installs company at start-up, then I get the same message. This is with Emacs HEAD as of a couple of days ago.

Steve Purcell

And just to confirm, the prompt indeed relates to emacs-lisp-docstring-fill-column.

Dmitry Gutov
Owner

Evaluating (package-install 'company) doesn't do it for me either. Also a recent trunk build here, and package.el hasn't seen any changes that could be related for a while now.

If you found out what piece of your config exactly creates this problem, that would be helpful. Though I'd probably have to fix it on this side anyway.

Discussion on emacs-devel: http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00624.html

Steve Purcell

Okay, right, my bad -- it works fine in a clean Emacs. I have a local configuration tweak which closes any dangling -autoloads files after package installation (since package.el used to leave such buffers lying around), and that caused the prompt. Sorry for the noise...

Steve Purcell purcell closed this
Dmitry Gutov
Owner

It's good to know that the problem is not in some third-party package.

Steve Purcell

Nope, just good old-fashioned Pilot Error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.