Stop completion about tempo if no matching prefix #1147
Conversation
|
Before this patch, a single
After this patch, only matched prefixes will trigger the completion. It makes senses.
|
|
I found more characters can lead to completion before this patch, e.g. |
|
Do you only see this problem with What's your value of |
3, the default. It can be reproduced by the following company conf. (use-package company
:ensure t
:hook (prog-mode . company-mode)
:bind (:map company-mode-map
([remap completion-at-point] . company-complete)
:map company-active-map
("C-s" . company-filter-candidates)
([tab] . company-complete-common-or-cycle)
([backtab] . company-select-previous-or-abort))
:custom
(company-idle-delay 0)
;; Easy navigation to candidates with M-<n>
(company-show-quick-access t)
(company-require-match nil)
(company-minimum-prefix-length 3)
(company-tooltip-width-grow-only t)
(company-tooltip-align-annotations t)
;; complete `abbrev' only in current buffer and make dabbrev case-sensitive
(company-dabbrev-other-buffers nil)
(company-dabbrev-ignore-case nil)
(company-dabbrev-downcase nil)
;; make dabbrev-code case-sensitive
(company-dabbrev-code-ignore-case nil)
(company-dabbrev-code-everywhere t)
;; call `tempo-expand-if-complete' after completion
(company-tempo-expand t)
;; Stop annoying me
(company-etags-use-main-table-list nil)
;; No icons
(company-format-margin-function nil)
(company-backends '((company-capf :with company-tempo)
company-files
(company-dabbrev-code company-keywords)
company-dabbrev
;; HACK: prevent `lsp-mode' to add `company-capf' back.
company-capf)))
;; lsp-mode
(use-package lsp-mode
:ensure t
:hook ((lsp-mode . lsp-enable-which-key-integration)
(prog-mode . lsp-deferred))
:bind (:map lsp-mode-map
("C-c f" . lsp-format-region)
("C-c d" . lsp-describe-thing-at-point)
("C-c a" . lsp-execute-code-action)
("C-c r" . lsp-rename))
:custom
(lsp-keymap-prefix "C-c l")
(lsp-enable-links nil) ;; no clickable links
(lsp-enable-folding nil) ;; use `hideshow' instead
(lsp-enable-snippet nil) ;; no snippets, it requires `yasnippet'
(lsp-enable-file-watchers nil) ;; performance matters
(lsp-enable-text-document-color nil) ;; as above
(lsp-enable-symbol-highlighting nil) ;; as above
(lsp-enable-on-type-formatting nil) ;; as above
(lsp-enable-indentation nil) ;; don't change my code without my permission
(lsp-headerline-breadcrumb-enable nil) ;; keep headline clean
(lsp-modeline-code-actions-enable nil) ;; keep modeline clean
(lsp-modeline-diagnostics-enable nil) ;; as above
(lsp-log-io nil) ;; debug only
(lsp-auto-guess-root t) ;; auto guess root
(lsp-keep-workspace-alive nil) ;; auto kill lsp server
(lsp-eldoc-enable-hover nil)) ;; disable eldoc hover
(use-package tempo
:ensure nil
:after cc-mode
:hook ((c-mode . c-mode-tempo-setup)
(c++-mode . c++-mode-tempo-setup))
:config
(defvar c-tempo-tags nil)
(defvar c++-tempo-tags nil)
(defun c-mode-tempo-setup ()
(tempo-use-tag-list 'c-tempo-tags))
(defun c++-mode-tempo-setup ()
(tempo-use-tag-list 'c-tempo-tags)
(tempo-use-tag-list 'c++-tempo-tags))
(tempo-define-template "c-ifndef"
'("#ifndef " (P "ifndef-clause: " clause) > n
"#define " (s clause) n> p n
"#endif // " (s clause) n>
)
"ifndef"
"Insert #ifndef #define #endif directives"
'c-tempo-tags)
(tempo-define-template "c-main"
'("int main(int argc, char* argv[]) {" > n>
p n
"}" > n>
)
"main"
"Insert a main function"
'c-tempo-tags)
(tempo-define-template "c++-class-equality"
'((P "type: " type 'noinsert)
(tempo-save-named 'inline (if (y-or-n-p "Inline? ") "inline " ""))
(tempo-save-named 'constexpr (if (y-or-n-p "Constexpr? ") "constexpr " ""))
(tempo-save-named 'noexcept (if (y-or-n-p "Noexcept? ") "noexcept " ""))
(s inline) (s constexpr) "bool operator==(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
p n
"}" > n>
(s inline) (s constexpr) "bool operator!=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs == rhs);" > n>
"}" > n>
)
"eq"
"Class equality comparison"
'c++-tempo-tags)
(tempo-define-template "c++-class-totally-ordered"
'((P "type: " type 'noinsert)
(tempo-save-named 'inline (if (y-or-n-p "Inline? ") "inline " ""))
(tempo-save-named 'constexpr (if (y-or-n-p "Constexpr? ") "constexpr " ""))
(tempo-save-named 'noexcept (if (y-or-n-p "Noexcept? ") "noexcept " ""))
(s inline) (s constexpr) "bool operator<(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
p n
"}" > n>
(s inline) (s constexpr) "bool operator>(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return rhs < lhs;" > n>
"}" > n>
(s inline) (s constexpr) "bool operator<=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs > rhs);" > n>
"}" > n>
(s inline) (s constexpr) "bool operator>=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs < rhs);" > n>
"}" > n>
)
"ord"
"Class totally ordered comparison"
'c++-tempo-tags))Open a cpp file, then type
|
Did you check the value at runtime, or did you just look at the config for the answer? I don't have I tried reproducing this problem by copying just the necessary parts of your config and failed. The templates were working, but no trace of the problem from the description. |
Both are 3.
After using (require 'tempo)
(require 'cc-mode)
(setq company-backends '((company-clang :with company-tempo)
company-files
(company-dabbrev-code company-keywords)
company-dabbrev))
(setq company-idle-delay 0)
(setq company-require-match nil)
(setq company-minimum-prefix-length 3)
(setq company-tempo-expand t)
(defvar c-tempo-tags nil)
(defvar c++-tempo-tags nil)
(defun c-mode-tempo-setup ()
(tempo-use-tag-list 'c-tempo-tags))
(defun c++-mode-tempo-setup ()
(tempo-use-tag-list 'c-tempo-tags)
(tempo-use-tag-list 'c++-tempo-tags))
(tempo-define-template "c-ifndef"
'("#ifndef " (P "ifndef-clause: " clause) > n
"#define " (s clause) n> p n
"#endif // " (s clause) n>
)
"ifndef"
"Insert #ifndef #define #endif directives"
'c-tempo-tags)
(tempo-define-template "c-main"
'("int main(int argc, char* argv[]) {" > n>
p n
"}" > n>
)
"main"
"Insert a main function"
'c-tempo-tags)
(tempo-define-template "c++-class-equality"
'((P "type: " type 'noinsert)
(tempo-save-named 'inline (if (y-or-n-p "Inline? ") "inline " ""))
(tempo-save-named 'constexpr (if (y-or-n-p "Constexpr? ") "constexpr " ""))
(tempo-save-named 'noexcept (if (y-or-n-p "Noexcept? ") "noexcept " ""))
(s inline) (s constexpr) "bool operator==(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
p n
"}" > n>
(s inline) (s constexpr) "bool operator!=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs == rhs);" > n>
"}" > n>
)
"eq"
"Class equality comparison"
'c++-tempo-tags)
(tempo-define-template "c++-class-totally-ordered"
'((P "type: " type 'noinsert)
(tempo-save-named 'inline (if (y-or-n-p "Inline? ") "inline " ""))
(tempo-save-named 'constexpr (if (y-or-n-p "Constexpr? ") "constexpr " ""))
(tempo-save-named 'noexcept (if (y-or-n-p "Noexcept? ") "noexcept " ""))
(s inline) (s constexpr) "bool operator<(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
p n
"}" > n>
(s inline) (s constexpr) "bool operator>(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return rhs < lhs;" > n>
"}" > n>
(s inline) (s constexpr) "bool operator<=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs > rhs);" > n>
"}" > n>
(s inline) (s constexpr) "bool operator>=(const " (s type) "& lhs, const " (s type) "& rhs) " (s noexcept) "{" > n>
"return !(lhs < rhs);" > n>
"}" > n>
)
"ord"
"Class totally ordered comparison"
'c++-tempo-tags)
(add-hook 'c++-mode-hook #'c++-mode-tempo-setup)Open a cpp file, type
More cases
|
So basically after any If so, I think I understand what's going on. |
Yes, you're right. All |
|
The problem: We have a mechanism that "overrides" the actual prefix length for the returned prefix string, when we want, in certain contexts, to initiate idle completion right away. Then that backend returns a cons
Grouped backends work behind an adapter that combines them together to make them look like a single backend. But there is no good way to combine such hints (or at least none have been implemented so far) that would retain the difference between the backends WRT triggers depending on the context. What it does is simple: if the first backend says "go", completions are collected from all of them. Not sure what's a good approach to improve this. I suppose the multi-backend adapter in its Your particular patch here seems like it will break |
…eparately This should help with #1398, #641, #553, #485, #1147, #840 With some of the above already closed, and some describing more serious scenarios than others. Anyway, this is a halfway step to dropping framework-level caching (or moving it to backends). For now this seems like an adequate solution, given that the most "heavy" backend these days is `company-capf`, which disables caching already. Though `company-dabbrev-code` is a close next.
…eparately (#1405) * company--multi-backend-adapter: Consider min prefix in 'candidates' separately This should help with #1398, #641, #553, #485, #1147, #840 With some of the above already closed, and some describing more serious scenarios than others. Anyway, this is a halfway step to dropping framework-level caching (or moving it to backends). For now this seems like an adequate solution (resetting the cache sometimes when the new chars are typed), given that the most "heavy" backend these days is `company-capf`, which disables caching already. Though `company-dabbrev-code` is a close next. Uses new semi-private backend action called 'set-min-prefix', to keep the merging function's backward compatibility, for the sake of external callers.
|
Turns out this could be managed inside the framework. Check out the latest master. |
No description provided.