Skip to content

Yield pipes instead of extending lists over and over #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomvanmele merged 1 commit into from
Sep 4, 2018
Merged

Yield pipes instead of extending lists over and over #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/compas_ghpython/utilities/drawing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ def xdraw_cylinders(cylinders, cap=False):


def xdraw_pipes(pipes, cap=2, fit=1.0):
rg_pipes = []
abs_tol = TOL
ang_tol = sc.doc.ModelAngleToleranceRadians
for p in pipes:
Expand All @@ -159,12 +158,12 @@ def xdraw_pipes(pipes, cap=2, fit=1.0):
if type(radius) in (int, float):
radius = [radius] * 2
radius = [float(r) for r in radius]

rail = Curve.CreateControlPointCurve([Point3d(*xyz) for xyz in points])
breps = Brep.CreatePipe(rail, params, radius, 1, cap, fit, abs_tol,
ang_tol)
rg_pipes += breps
return rg_pipes

for brep in breps:
yield brep

def xdraw_spheres(spheres):
rg_sheres = []
Expand Down