Skip to content

Commit 26fb779

Browse files
committed
feat(code-gen/experimental: few percent speedup of array validation
At some array size, setting the `[].length = 1000` is even faster. However, many more use-cases have smaller arrays, so let's go for that.
1 parent 598694d commit 26fb779

File tree

5 files changed

+123
-304
lines changed

5 files changed

+123
-304
lines changed

packages/cli/src/generated/cli/validators.js

Lines changed: 4 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/code-gen/src/experimental/generated/experimental/validators.js

Lines changed: 19 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/code-gen/src/experimental/validators/javascript.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -604,10 +604,7 @@ export function validatorJavascriptArray(file, type, validatorState) {
604604
}
605605

606606
// Initialize result array
607-
fileWrite(
608-
file,
609-
`${resultPath} = Array.from({ length: ${currentValuePath}.length });`,
610-
);
607+
fileWrite(file, `${resultPath} = [];`);
611608

612609
// Loop through array
613610
const idxVariable = `i${validatorState.reusedVariableIndex++}`;

packages/store/src/generated/queryResult/validators.js

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)