feat(eslint-plugin): stricter checks on missing eventStart calls

BREAKING CHANGE:
- Correctness checks; if `event` is passed into an async function, you most certainly want to call `eventStart`.

Author: dirkdev98

packages/eslint-plugin/lint-rules/check-event-name.js

@@ -13,6 +13,9 @@ module.exports = {
       consistentEventName:
         "Use an event name that can be derived from the function name",
       replaceEventName: `Replace value with {{value}}`,
+      missingEventStart:
+        "Function accepts 'event' as the first argument, but doesn't call 'eventStart'.",
+      addEventStart: `Add 'eventStart(event, "")' in your function body.`,
     },
   },
 
@@ -23,12 +26,36 @@ module.exports = {
       currentFunction = {
         parent: currentFunction,
         node,
-        isAsyncEventFunction: node.async && node.params[0]?.name === "event",
+        isAsyncEventFunction:
+          node.async && node.id?.name && node.params[0]?.name === "event",
+        hasEventStart: false,
         functionName: node.id?.name,
       };
     }
 
     function processFunctionEnd() {
+      if (
+        currentFunction?.isAsyncEventFunction &&
+        !currentFunction.hasEventStart
+      ) {
+        context.report({
+          node: currentFunction.node.body,
+          messageId: "missingEventStart",
+          suggest: [
+            {
+              messageId: "addEventStart",
+              data: {},
+              fix: function (fixer) {
+                return fixer.insertTextBefore(
+                  currentFunction.node.body.body[0],
+                  `eventStart(event, "");\n  `,
+                );
+              },
+            },
+          ],
+        });
+      }
+
       currentFunction = currentFunction.parent;
     }
 
@@ -39,18 +66,16 @@ module.exports = {
 
       // Process `eventStart` calls
       "CallExpression[callee.name='eventStart']"(node) {
-        if (
-          !currentFunction.isAsyncEventFunction ||
-          !currentFunction.functionName ||
-          currentFunction.functionName.length === 0
-        ) {
+        if (!currentFunction?.isAsyncEventFunction) {
           return;
         }
 
         if (node.arguments?.length !== 2) {
           return;
         }
 
+        currentFunction.hasEventStart = true;
+
         let value = undefined;
         if (node.arguments[1].type === "Literal") {
           value = node.arguments[1].value;

packages/eslint-plugin/test/check-event-name.js

@@ -61,6 +61,22 @@ ruleTester.run("check-event-name", rule, {
     },
   ],
   invalid: [
+    {
+      code: `async function missingEventStart(event) { const foo = 5; }`,
+      errors: [
+        {
+          message: rule.meta.messages.missingEventStart,
+          suggestions: [
+            {
+              messageId: "addEventStart",
+              data: {},
+              output: `async function missingEventStart(event) { eventStart(event, "");
+  const foo = 5; }`,
+            },
+          ],
+        },
+      ],
+    },
     {
       code: `async function fooBar(event) { eventStart(event, "foo"); }`,
       errors: [

packages/eslint-plugin/test/node-builtin-module-url-import.js

@@ -33,6 +33,7 @@ ruleTester.run("node-builtin-module-url-import", rule, {
   invalid: [
     {
       code: `import { join } from "path";`,
+      output: `import { join } from "node:path";`,
       errors: [
         {
           message: rule.meta.messages.consistentImport,