-
Notifications
You must be signed in to change notification settings - Fork 1
Add Code Coverage and Clang-tidy #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Coverage and Clang-tidy #11
Conversation
clang tidy post Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
fe46a6a to
2fa3604
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
The chromosome test is flaky passes locally but sometimes fails here |
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com> update cmake Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com> clang changes Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
88ca83c to
3192baa
Compare
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
4aeeac1 to
ebdb86a
Compare
That’s an indicator of a problem. Can you run with valgrind? |
|
It was a race condition I have fixed it using global mutex. |
vgvassilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
This PR adds Code coverage and clang-tidy workflow to the project.
The changes made are:-