Skip to content

Conversation

@AdityaPandeyCN
Copy link

This PR adds region query performance of RNTuple vs TTree benchmark.

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Comment on lines 8 to 12
#ifdef _WIN32
#define NULL_DEVICE "NUL"
#else
#define NULL_DEVICE "/dev/null"
#endif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this was already put somewhere. Can we make sure we reuse code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to address this.

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 252c3ba into compiler-research:develop Oct 4, 2025
3 checks passed
AdityaPandeyCN added a commit to AdityaPandeyCN/ramtools that referenced this pull request Oct 4, 2025
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang format

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

code organization

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

Add region query benchmark (compiler-research#8)

* query performance

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang format

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* code organization

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

---------

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

add chromosome based file splitting

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

delete example sam file

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

test file changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
vgvassilev pushed a commit that referenced this pull request Oct 16, 2025
* Adding chromosome base file splitting

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang format

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

code organization

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

Add region query benchmark (#8)

* query performance

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang format

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* code organization

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

---------

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

add chromosome based file splitting

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

delete example sam file

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

test file changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* added bam vs ram file benchmark for chromosome based file splitting

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang format changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* made benchmarks fair

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* parallel write code

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* version update

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* version update

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* use parallel writer

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* samtools threading

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

* clang format changes

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>

---------

Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants