This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Sortable panels #229
Merged
Sortable panels #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about we combine this with another small visual tweak I was going to suggest in 228, and enlarge the colored accent and make it the drag handle? |
Uses react-sortable-hoc, which was already included for the Filter UI. `withAnswerDistributionCharts.js` is largely a move of `AnswerDistributionPanels.js`. In order to manage sorting, we work with the underlying array, rather than directly rendering the dynamically-created panels. WorkspaceScreen now relies on the HOCs to provide its [shared] data: sessions first, then the answer distribution charts.
API logging is getting noisier; probably will not be needed outside development.
bryfox
force-pushed
the
feature/sortable-panels
branch
from
9bb2356
to
7c8ed3b
Compare
|
I rebased this onto master & pushed the drag handle change. The handles don't particularly look draggable until hover, but that might be fine for this feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the grid items on a workspace draggable and sortable so that a user can configure chart positions. The order is stored & persisted with redux state, separately from excluded chart preferences.
This depends on #228, which is still under review.
Known issue: text on panels is no longer selectable. I was considering merging the counts & stats panels, and having the three text-heavy panels in an undraggable (and text-selectable) top row. We could instead have some sort of drag handle on each panel, or toggle a 'dragging' mode if needed.