From e51f569f8091b08b01892a350a129e2ebe80d1f5 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 11 Sep 2025 20:38:59 -0700 Subject: [PATCH 1/6] Remove unused matrix settings --- .github/workflows/build-toolchain.yml | 189 -------------------------- 1 file changed, 189 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index e99e149a6..07ab2985f 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -402,12 +402,6 @@ jobs: "triple": "x86_64-unknown-windows-msvc", "compiler_target": "x86_64-unknown-windows-msvc", "os": "Windows", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }}\" -D CMAKE_STATIC_LIBRARY_PREFIX_Swift=lib", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=AMD64" }, { "arch": "arm64", @@ -415,12 +409,6 @@ jobs: "triple": "aarch64-unknown-windows-msvc", "compiler_target": "aarch64-unknown-windows-msvc", "os": "Windows", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }}\" -D CMAKE_STATIC_LIBRARY_PREFIX_Swift=lib", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=ARM64" } ] } @@ -433,12 +421,6 @@ jobs: "triple": "aarch64-unknown-windows-msvc", "compiler_target": "aarch64-unknown-windows-msvc", "os": "Windows", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }}\" -D CMAKE_STATIC_LIBRARY_PREFIX_Swift=lib", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=ARM64" } ] } @@ -450,11 +432,6 @@ jobs: "cpu": "x86_64", "compiler_target": "x86_64-unknown-windows-msvc", "os": "Windows", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=AMD64" } ] } @@ -466,11 +443,6 @@ jobs: "cpu": "aarch64", "compiler_target": "aarch64-unknown-windows-msvc", "os": "Windows", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=ARM64" } ] } @@ -483,18 +455,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "x86_64-unknown-windows-msvc", - "triple_no_api_level": "x86_64-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=AMD64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=amd64 -D MSVC_CXX_ARCHITECTURE_ID=amd64 -D CMAKE_STATIC_LIBRARY_PREFIX_Swift=lib" }, { "arch": "arm64", @@ -502,18 +462,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "aarch64-unknown-windows-msvc", - "triple_no_api_level": "aarch64-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=ARM64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=arm64 -D MSVC_CXX_ARCHITECTURE_ID=arm64 -D CMAKE_STATIC_LIBRARY_PREFIX_Swift=lib" }, { "arch": "x86", @@ -521,18 +469,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "i686-unknown-windows-msvc", - "triple_no_api_level": "i686-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=X86", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=x86 -D MSVC_CXX_ARCHITECTURE_ID=x86" }, { "arch": "arm64", @@ -540,18 +476,6 @@ jobs: "os": "Android", "platform": "Android", "triple": "aarch64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "triple_no_api_level": "aarch64-unknown-linux-android", - "cc": "clang", - "cflags": "${{ steps.context.outputs.ANDROID_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.ANDROID_CMAKE_CXX_FLAGS }}", - "swiftflags": "-sdk ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -target -Xclang-linker aarch64-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }} -Xclang-linker --sysroot -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -resource-dir -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/lib/clang/${{ steps.context.outputs.ANDROID_CLANG_VERSION }} -L ${env:GITHUB_WORKSPACE}/BinaryCache/swift/lib/swift/android -g", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "-D CMAKE_ANDROID_NDK=\"${NDKPATH}\" -D SWIFT_ANDROID_NDK_PATH=\"${NDKPATH}\"", - "extra_flags": "-D CMAKE_ANDROID_API=${{ inputs.ANDROID_API_LEVEL }} -D CMAKE_ANDROID_ARCH_ABI=arm64-v8a", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr", - "llvm_cmake_flags": "-D LLVM_HOST_TRIPLE=aarch64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "stdlib_cmake_flags": "-D LLVM_ENABLE_LIBCXX=YES -D SWIFT_USE_LINKER=lld -D CMAKE_SYSTEM_PROCESSOR=aarch64" }, { "arch": "armv7", @@ -559,18 +483,6 @@ jobs: "os": "Android", "platform": "Android", "triple": "armv7-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }}", - "triple_no_api_level": "armv7-unknown-linux-androideabi", - "cc": "clang", - "cflags": "${{ steps.context.outputs.ANDROID_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.ANDROID_CMAKE_CXX_FLAGS }}", - "swiftflags": "-sdk ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -target -Xclang-linker armv7a-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }} -Xclang-linker --sysroot -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -resource-dir -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/lib/clang/${{ steps.context.outputs.ANDROID_CLANG_VERSION }} -L ${env:GITHUB_WORKSPACE}/BinaryCache/swift/lib/swift/android -g", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "-D CMAKE_ANDROID_NDK=\"${NDKPATH}\" -D SWIFT_ANDROID_NDK_PATH=\"${NDKPATH}\"", - "extra_flags": "-D CMAKE_ANDROID_API=${{ inputs.ANDROID_API_LEVEL }} -D CMAKE_ANDROID_ARCH_ABI=armeabi-v7a", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr", - "llvm_cmake_flags": "-D LLVM_HOST_TRIPLE=armv7a-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }}", - "stdlib_cmake_flags": "-D LLVM_ENABLE_LIBCXX=YES -D SWIFT_USE_LINKER=lld -D CMAKE_SYSTEM_PROCESSOR=armv7-a" }, { "arch": "i686", @@ -578,18 +490,6 @@ jobs: "os": "Android", "platform": "Android", "triple": "i686-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "triple_no_api_level": "i686-unknown-linux-android", - "cc": "clang", - "cflags": "${{ steps.context.outputs.ANDROID_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.ANDROID_CMAKE_CXX_FLAGS }}", - "swiftflags": "-sdk ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -target -Xclang-linker i686-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }} -Xclang-linker --sysroot -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -resource-dir -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/lib/clang/${{ steps.context.outputs.ANDROID_CLANG_VERSION }} -L ${env:GITHUB_WORKSPACE}/BinaryCache/swift/lib/swift/android -g", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "-D CMAKE_ANDROID_NDK=\"${NDKPATH}\" -D SWIFT_ANDROID_NDK_PATH=\"${NDKPATH}\"", - "extra_flags": "-D CMAKE_ANDROID_API=${{ inputs.ANDROID_API_LEVEL }} -D CMAKE_ANDROID_ARCH_ABI=x86", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr", - "llvm_cmake_flags": "-D LLVM_HOST_TRIPLE=i686-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "stdlib_cmake_flags": "-D LLVM_ENABLE_LIBCXX=YES -D SWIFT_USE_LINKER=lld -D CMAKE_SYSTEM_PROCESSOR=i686" }, { "arch": "x86_64", @@ -597,18 +497,6 @@ jobs: "os": "Android", "platform": "Android", "triple": "x86_64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "triple_no_api_level": "x86_64-unknown-linux-android", - "cc": "clang", - "cflags": "${{ steps.context.outputs.ANDROID_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.ANDROID_CMAKE_CXX_FLAGS }}", - "swiftflags": "-sdk ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -target -Xclang-linker x86_64-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }} -Xclang-linker --sysroot -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -resource-dir -Xclang-linker ${NDKPATH}/toolchains/llvm/prebuilt/windows-x86_64/lib/clang/${{ steps.context.outputs.ANDROID_CLANG_VERSION }} -L ${env:GITHUB_WORKSPACE}/BinaryCache/swift/lib/swift/android -g", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "-D CMAKE_ANDROID_NDK=\"${NDKPATH}\" -D SWIFT_ANDROID_NDK_PATH=\"${NDKPATH}\"", - "extra_flags": "-D CMAKE_ANDROID_API=${{ inputs.ANDROID_API_LEVEL }} -D CMAKE_ANDROID_ARCH_ABI=x86_64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr", - "llvm_cmake_flags": "-D LLVM_HOST_TRIPLE=x86_64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", - "stdlib_cmake_flags": "-D LLVM_ENABLE_LIBCXX=YES -D SWIFT_USE_LINKER=lld -D CMAKE_SYSTEM_PROCESSOR=x86_64" } ] } @@ -621,18 +509,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "x86_64-unknown-windows-msvc", - "triple_no_api_level": "x86_64-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=AMD64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=amd64 -D MSVC_CXX_ARCHITECTURE_ID=amd64" }, { "arch": "arm64", @@ -640,18 +516,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "aarch64-unknown-windows-msvc", - "triple_no_api_level": "aarch64-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=ARM64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=arm64 -D MSVC_CXX_ARCHITECTURE_ID=arm64" }, { "arch": "x86", @@ -659,18 +523,6 @@ jobs: "os": "Windows", "platform": "Windows", "triple": "i686-unknown-windows-msvc", - "triple_no_api_level": "i686-unknown-windows-msvc", - "cc": "cl", - "cflags": "${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }}", - "cxx": "cl", - "cxxflags": "${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=X86", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "-D MSVC_C_ARCHITECTURE_ID=x86 -D MSVC_CXX_ARCHITECTURE_ID=x86" } ] } @@ -681,23 +533,11 @@ jobs: "arch": "x86_64", "cpu": "x86_64", "os": "Darwin", - "cc": "clang", - "cflags": "${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_SHARED_LINKER_FLAGS }}\"", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=x86_64 -D CMAKE_OSX_DEPLOYMENT_TARGET=15.0 -D CMAKE_OSX_ARCHITECTURES=x86_64" }, { "arch": "arm64", "cpu": "arm64", "os": "Darwin", - "cc": "clang", - "cflags": "${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=${{ steps.context.outputs.DARWIN_CMAKE_EXE_LINKER_FLAGS }} -D CMAKE_SHARED_LINKER_FLAGS=${{ steps.context.outputs.DARWIN_CMAKE_SHARED_LINKER_FLAGS }}", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=arm64 -D CMAKE_OSX_DEPLOYMENT_TARGET=15.0 -D CMAKE_OSX_ARCHITECTURES=arm64" } ] } @@ -709,11 +549,6 @@ jobs: "cpu": "arm64", "compiler_target": "arm64-apple-macosx15.0", "os": "Darwin", - "cc": "clang", - "cflags": "${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }}", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=arm64 -D CMAKE_OSX_DEPLOYMENT_TARGET=15.0 -D CMAKE_OSX_ARCHITECTURES=arm64" } ] } @@ -726,18 +561,6 @@ jobs: "os": "Darwin", "platform": "MacOSX", "triple": "x86_64-apple-macosx15.0", - "triple_no_api_level": "x86_64-apple-macosx15.0", - "cc": "clang", - "cflags": "${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.DARWIN_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=x86_64 -D CMAKE_OSX_DEPLOYMENT_TARGET=15.0 -D CMAKE_OSX_ARCHITECTURES=x86_64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Toolchains/${{ steps.context.outputs.swift_version }}+Asserts/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "" }, { "arch": "arm64", @@ -745,18 +568,6 @@ jobs: "os": "Darwin", "platform": "MacOSX", "triple": "arm64-apple-macosx15.0", - "triple_no_api_level": "arm64-apple-macosx15.0", - "cc": "clang", - "cflags": "${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }}", - "cxx": "clang++", - "cxxflags": "${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }}", - "swiftflags": "${{ steps.context.outputs.DARWIN_CMAKE_Swift_FLAGS }}", - "cmake_linker_flags": "-D CMAKE_EXE_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_EXE_LINKER_FLAGS }}\" -D CMAKE_SHARED_LINKER_FLAGS=\"${{ steps.context.outputs.DARWIN_CMAKE_SHARED_LINKER_FLAGS }}\"", - "cmake_ndk_flags": "", - "extra_flags": "-D CMAKE_SYSTEM_PROCESSOR=arm64 -D CMAKE_OSX_DEPLOYMENT_TARGET=15.0 -D CMAKE_OSX_ARCHITECTURES=arm64", - "sdk_install_dir": "${env:GITHUB_WORKSPACE}/BuildRoot/Library/Developer/Toolchains/${{ steps.context.outputs.swift_version }}+Asserts/usr", - "llvm_cmake_flags": "", - "stdlib_cmake_flags": "" } ] } From 4d50762af571100836cc55d34d3201cafea6e2bf Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 11 Sep 2025 20:40:51 -0700 Subject: [PATCH 2/6] Use triple instead of compiler_target --- .github/workflows/build-toolchain.yml | 9 +++------ .github/workflows/swift-toolchain.yml | 2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index 07ab2985f..fe17c8ac6 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -400,14 +400,12 @@ jobs: "arch": "amd64", "cpu": "x86_64", "triple": "x86_64-unknown-windows-msvc", - "compiler_target": "x86_64-unknown-windows-msvc", "os": "Windows", }, { "arch": "arm64", "cpu": "aarch64", "triple": "aarch64-unknown-windows-msvc", - "compiler_target": "aarch64-unknown-windows-msvc", "os": "Windows", } ] @@ -419,7 +417,6 @@ jobs: "arch": "arm64", "cpu": "aarch64", "triple": "aarch64-unknown-windows-msvc", - "compiler_target": "aarch64-unknown-windows-msvc", "os": "Windows", } ] @@ -430,7 +427,7 @@ jobs: { "arch": "amd64", "cpu": "x86_64", - "compiler_target": "x86_64-unknown-windows-msvc", + "triple": "x86_64-unknown-windows-msvc", "os": "Windows", } ] @@ -441,7 +438,7 @@ jobs: { "arch": "arm64", "cpu": "aarch64", - "compiler_target": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc", "os": "Windows", } ] @@ -547,7 +544,7 @@ jobs: { "arch": "arm64", "cpu": "arm64", - "compiler_target": "arm64-apple-macosx15.0", + "triple": "arm64-apple-macosx15.0", "os": "Darwin", } ] diff --git a/.github/workflows/swift-toolchain.yml b/.github/workflows/swift-toolchain.yml index 59a567383..4704ef7bf 100644 --- a/.github/workflows/swift-toolchain.yml +++ b/.github/workflows/swift-toolchain.yml @@ -880,7 +880,7 @@ jobs: --configuration release ` --package-path ${{ github.workspace }}/SourceCache/swift-driver ` --build-path ${{ github.workspace }}/BinaryCache/swift-driver ` - --triple ${{ matrix.compiler_target }} ` + --triple ${{ matrix.triple }} ` @ExtraFlags - name: Copy binaries From 8d72e6aa8e98c0479309aaf5c9c589c26d01ef13 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 11 Sep 2025 21:11:05 -0700 Subject: [PATCH 3/6] Remove platform --- .github/workflows/build-toolchain.yml | 12 ------------ .github/workflows/swift-toolchain.yml | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index fe17c8ac6..b0097dbf2 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -450,49 +450,42 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "platform": "Windows", "triple": "x86_64-unknown-windows-msvc", }, { "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "platform": "Windows", "triple": "aarch64-unknown-windows-msvc", }, { "arch": "x86", "cpu": "i686", "os": "Windows", - "platform": "Windows", "triple": "i686-unknown-windows-msvc", }, { "arch": "arm64", "cpu": "aarch64", "os": "Android", - "platform": "Android", "triple": "aarch64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", }, { "arch": "armv7", "cpu": "armv7", "os": "Android", - "platform": "Android", "triple": "armv7-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }}", }, { "arch": "i686", "cpu": "i686", "os": "Android", - "platform": "Android", "triple": "i686-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", }, { "arch": "x86_64", "cpu": "x86_64", "os": "Android", - "platform": "Android", "triple": "x86_64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", } ] @@ -504,21 +497,18 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "platform": "Windows", "triple": "x86_64-unknown-windows-msvc", }, { "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "platform": "Windows", "triple": "aarch64-unknown-windows-msvc", }, { "arch": "x86", "cpu": "i686", "os": "Windows", - "platform": "Windows", "triple": "i686-unknown-windows-msvc", } ] @@ -556,14 +546,12 @@ jobs: "arch": "x86_64", "cpu": "x86_64", "os": "Darwin", - "platform": "MacOSX", "triple": "x86_64-apple-macosx15.0", }, { "arch": "arm64", "cpu": "arm64", "os": "Darwin", - "platform": "MacOSX", "triple": "arm64-apple-macosx15.0", } ] diff --git a/.github/workflows/swift-toolchain.yml b/.github/workflows/swift-toolchain.yml index 4704ef7bf..8b56cf877 100644 --- a/.github/workflows/swift-toolchain.yml +++ b/.github/workflows/swift-toolchain.yml @@ -1750,7 +1750,7 @@ jobs: android-clang-version: ${{ inputs.ANDROID_CLANG_VERSION }} ndk-path: ${{ steps.setup-ndk.outputs.ndk-path }} built-compilers: '@("C", "CXX", "Swift")' - cache-script: ${{ github.workspace }}/SourceCache/swift/cmake/caches/Runtime-${{ matrix.platform }}-${{ matrix.cpu }}.cmake + cache-script: ${{ github.workspace }}/SourceCache/swift/cmake/caches/Runtime-${{ matrix.os == 'Darwin' && 'MacOSX' || matrix.os }}-${{ matrix.cpu }}.cmake cmake-defines: | @{ 'LLVM_DIR' = "${{ github.workspace }}/BinaryCache/llvm/lib/cmake/llvm"; From 41bfca6b7db548c220c779ebe21adf833b9d58a8 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 11 Sep 2025 21:13:56 -0700 Subject: [PATCH 4/6] Reorder things --- .github/workflows/build-toolchain.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index b0097dbf2..08302771c 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -399,14 +399,14 @@ jobs: { "arch": "amd64", "cpu": "x86_64", - "triple": "x86_64-unknown-windows-msvc", "os": "Windows", + "triple": "x86_64-unknown-windows-msvc", }, { "arch": "arm64", "cpu": "aarch64", - "triple": "aarch64-unknown-windows-msvc", "os": "Windows", + "triple": "aarch64-unknown-windows-msvc", } ] } @@ -416,8 +416,8 @@ jobs: { "arch": "arm64", "cpu": "aarch64", - "triple": "aarch64-unknown-windows-msvc", "os": "Windows", + "triple": "aarch64-unknown-windows-msvc", } ] } @@ -427,8 +427,8 @@ jobs: { "arch": "amd64", "cpu": "x86_64", - "triple": "x86_64-unknown-windows-msvc", "os": "Windows", + "triple": "x86_64-unknown-windows-msvc", } ] } @@ -438,8 +438,8 @@ jobs: { "arch": "arm64", "cpu": "aarch64", - "triple": "aarch64-unknown-windows-msvc", "os": "Windows", + "triple": "aarch64-unknown-windows-msvc", } ] } @@ -534,8 +534,8 @@ jobs: { "arch": "arm64", "cpu": "arm64", - "triple": "arm64-apple-macosx15.0", "os": "Darwin", + "triple": "arm64-apple-macosx15.0", } ] } From 722e96910fcfe63c43e0c53e669633e9c4242422 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 11 Sep 2025 21:40:18 -0700 Subject: [PATCH 5/6] Remove unusued flags --- .github/workflows/build-toolchain.yml | 58 --------------------------- .github/workflows/swift-toolchain.yml | 36 ----------------- 2 files changed, 94 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index 08302771c..910228bfa 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -193,22 +193,8 @@ jobs: zlib_revision: ${{ steps.context.outputs.zlib_revision }} zlib_version: ${{ steps.context.outputs.zlib_version }} ANDROID_API_LEVEL: ${{ steps.context.outputs.ANDROID_API_LEVEL }} - WINDOWS_CMAKE_C_FLAGS: ${{ steps.context.outputs.WINDOWS_CMAKE_C_FLAGS }} - WINDOWS_CMAKE_CXX_FLAGS: ${{ steps.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }} - WINDOWS_CMAKE_EXE_LINKER_FLAGS: ${{ steps.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }} - WINDOWS_CMAKE_SHARED_LINKER_FLAGS: ${{ steps.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }} - DARWIN_CMAKE_C_FLAGS: ${{ steps.context.outputs.DARWIN_CMAKE_C_FLAGS }} - DARWIN_CMAKE_CXX_FLAGS: ${{ steps.context.outputs.DARWIN_CMAKE_CXX_FLAGS }} - DARWIN_CMAKE_EXE_LINKER_FLAGS: ${{ steps.context.outputs.DARWIN_CMAKE_EXE_LINKER_FLAGS }} - DARWIN_CMAKE_SHARED_LINKER_FLAGS: ${{ steps.context.outputs.DARWIN_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_CLANG_VERSION: ${{ steps.context.outputs.ANDROID_CLANG_VERSION }} - ANDROID_CMAKE_C_FLAGS: ${{ steps.context.outputs.ANDROID_CMAKE_C_FLAGS }} - ANDROID_CMAKE_CXX_FLAGS: ${{ steps.context.outputs.ANDROID_CMAKE_CXX_FLAGS }} - ANDROID_CMAKE_EXE_LINKER_FLAGS: ${{ steps.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }} - ANDROID_CMAKE_SHARED_LINKER_FLAGS: ${{ steps.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_NDK_VERSION: ${{ steps.context.outputs.ANDROID_NDK_VERSION }} - WINDOWS_CMAKE_Swift_FLAGS: ${{ steps.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }} - DARWIN_CMAKE_Swift_FLAGS: ${{ steps.context.outputs.DARWIN_CMAKE_Swift_FLAGS }} debug_info: ${{ steps.context.outputs.debug_info }} signed: ${{ steps.context.outputs.signed }} swift_version: ${{ steps.context.outputs.swift_version }} @@ -313,35 +299,9 @@ jobs: # see: https://github.com/actions/runner-images/issues/10004 if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.debug_info }}" == "true" ]]; then echo debug_info=true >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_C_FLAGS="/GS- /Gw /Gy /Oi /Oy /Z7 /Zc:inline /Zc:preprocessor" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_CXX_FLAGS="/GS- /Gw /Gy /Oi /Oy /Z7 /Zc:inline /Zc:preprocessor /Zc:__cplusplus /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_C_FLAGS="-g" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_CXX_FLAGS="-g" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_EXE_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_SHARED_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo ANDROID_CMAKE_C_FLAGS="-ffunction-sections -fdata-sections -g -gsplit-dwarf" >> ${GITHUB_OUTPUT} - echo ANDROID_CMAKE_CXX_FLAGS="-ffunction-sections -fdata-sections -g -gsplit-dwarf" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_EXE_LINKER_FLAGS="-incremental:no -debug -opt:ref -opt:icf" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_SHARED_LINKER_FLAGS="-incremental:no -debug -opt:ref -opt:icf" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_Swift_FLAGS="-g -debug-info-format=codeview -Xlinker -debug -Xlinker -incremental:no -Xlinker -opt:ref -Xlinker -opt:icf" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_Swift_FLAGS="-g" >> ${GITHUB_OUTPUT} else echo debug_info=false >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_C_FLAGS="/GS- /Gw /Gy /Oi /Oy /Zc:inline /Zc:preprocessor" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_CXX_FLAGS="/GS- /Gw /Gy /Oi /Oy /Zc:inline /Zc:preprocessor /Zc:__cplusplus /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_C_FLAGS="" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_CXX_FLAGS="" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_EXE_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_SHARED_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo ANDROID_CMAKE_C_FLAGS="-ffunction-sections -fdata-sections" >> ${GITHUB_OUTPUT} - echo ANDROID_CMAKE_CXX_FLAGS="-ffunction-sections -fdata-sections" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_EXE_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_SHARED_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo WINDOWS_CMAKE_Swift_FLAGS="-Xlinker -incremental:no -Xlinker -opt:ref -Xlinker -opt:icf" >> ${GITHUB_OUTPUT} - echo DARWIN_CMAKE_Swift_FLAGS="" >> ${GITHUB_OUTPUT} fi - echo ANDROID_CMAKE_EXE_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} - echo ANDROID_CMAKE_SHARED_LINKER_FLAGS="" >> ${GITHUB_OUTPUT} if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.signed }}" == "true" ]]; then # FIXME(compnerd) enable this when requested @@ -643,17 +603,8 @@ jobs: zlib_revision: ${{ needs.context.outputs.zlib_revision }} zlib_version: ${{ needs.context.outputs.zlib_version }} ANDROID_API_LEVEL: ${{ needs.context.outputs.ANDROID_API_LEVEL }} - WINDOWS_CMAKE_C_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_C_FLAGS }} - WINDOWS_CMAKE_CXX_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }} - WINDOWS_CMAKE_EXE_LINKER_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }} - WINDOWS_CMAKE_SHARED_LINKER_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_CLANG_VERSION: ${{ needs.context.outputs.ANDROID_CLANG_VERSION }} - ANDROID_CMAKE_C_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_C_FLAGS }} - ANDROID_CMAKE_CXX_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_CXX_FLAGS }} - ANDROID_CMAKE_EXE_LINKER_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }} - ANDROID_CMAKE_SHARED_LINKER_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_NDK_VERSION: ${{ needs.context.outputs.ANDROID_NDK_VERSION }} - CMAKE_Swift_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_Swift_FLAGS }} debug_info: ${{ fromJSON(needs.context.outputs.debug_info) }} release: ${{ inputs.create_release }} signed: ${{ fromJSON(needs.context.outputs.signed) }} @@ -728,17 +679,8 @@ jobs: zlib_revision: ${{ needs.context.outputs.zlib_revision }} zlib_version: ${{ needs.context.outputs.zlib_version }} ANDROID_API_LEVEL: ${{ needs.context.outputs.ANDROID_API_LEVEL }} - WINDOWS_CMAKE_C_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_C_FLAGS }} - WINDOWS_CMAKE_CXX_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_CXX_FLAGS }} - WINDOWS_CMAKE_EXE_LINKER_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_EXE_LINKER_FLAGS }} - WINDOWS_CMAKE_SHARED_LINKER_FLAGS: ${{ needs.context.outputs.WINDOWS_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_CLANG_VERSION: ${{ needs.context.outputs.ANDROID_CLANG_VERSION }} - ANDROID_CMAKE_C_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_C_FLAGS }} - ANDROID_CMAKE_CXX_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_CXX_FLAGS }} - ANDROID_CMAKE_EXE_LINKER_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_EXE_LINKER_FLAGS }} - ANDROID_CMAKE_SHARED_LINKER_FLAGS: ${{ needs.context.outputs.ANDROID_CMAKE_SHARED_LINKER_FLAGS }} ANDROID_NDK_VERSION: ${{ needs.context.outputs.ANDROID_NDK_VERSION }} - CMAKE_Swift_FLAGS: ${{ needs.context.outputs.DARWIN_CMAKE_Swift_FLAGS }} debug_info: ${{ fromJSON(needs.context.outputs.debug_info) }} release: false signed: ${{ fromJSON(needs.context.outputs.signed) }} diff --git a/.github/workflows/swift-toolchain.yml b/.github/workflows/swift-toolchain.yml index 8b56cf877..260e05d19 100644 --- a/.github/workflows/swift-toolchain.yml +++ b/.github/workflows/swift-toolchain.yml @@ -203,42 +203,6 @@ on: required: true type: string - WINDOWS_CMAKE_C_FLAGS: - required: true - type: string - - WINDOWS_CMAKE_CXX_FLAGS: - required: true - type: string - - WINDOWS_CMAKE_EXE_LINKER_FLAGS: - required: true - type: string - - WINDOWS_CMAKE_SHARED_LINKER_FLAGS: - required: true - type: string - - ANDROID_CMAKE_C_FLAGS: - required: true - type: string - - ANDROID_CMAKE_CXX_FLAGS: - required: true - type: string - - ANDROID_CMAKE_EXE_LINKER_FLAGS: - required: true - type: string - - ANDROID_CMAKE_SHARED_LINKER_FLAGS: - required: true - type: string - - CMAKE_Swift_FLAGS: - required: true - type: string - debug_info: required: true type: boolean From 45985fc06dfe025cfbd36edecef8f0a49d1deca5 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Fri, 12 Sep 2025 08:49:59 -0700 Subject: [PATCH 6/6] Remove trailing commas from JSON --- .github/workflows/build-toolchain.yml | 40 +++++++++++++-------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/build-toolchain.yml b/.github/workflows/build-toolchain.yml index 910228bfa..37962a142 100644 --- a/.github/workflows/build-toolchain.yml +++ b/.github/workflows/build-toolchain.yml @@ -360,13 +360,13 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "triple": "x86_64-unknown-windows-msvc", + "triple": "x86_64-unknown-windows-msvc" }, { "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "triple": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc" } ] } @@ -377,7 +377,7 @@ jobs: "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "triple": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc" } ] } @@ -388,7 +388,7 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "triple": "x86_64-unknown-windows-msvc", + "triple": "x86_64-unknown-windows-msvc" } ] } @@ -399,7 +399,7 @@ jobs: "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "triple": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc" } ] } @@ -410,43 +410,43 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "triple": "x86_64-unknown-windows-msvc", + "triple": "x86_64-unknown-windows-msvc" }, { "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "triple": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc" }, { "arch": "x86", "cpu": "i686", "os": "Windows", - "triple": "i686-unknown-windows-msvc", + "triple": "i686-unknown-windows-msvc" }, { "arch": "arm64", "cpu": "aarch64", "os": "Android", - "triple": "aarch64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", + "triple": "aarch64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}" }, { "arch": "armv7", "cpu": "armv7", "os": "Android", - "triple": "armv7-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }}", + "triple": "armv7-unknown-linux-androideabi${{ inputs.ANDROID_API_LEVEL }}" }, { "arch": "i686", "cpu": "i686", "os": "Android", - "triple": "i686-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", + "triple": "i686-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}" }, { "arch": "x86_64", "cpu": "x86_64", "os": "Android", - "triple": "x86_64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}", + "triple": "x86_64-unknown-linux-android${{ inputs.ANDROID_API_LEVEL }}" } ] } @@ -457,19 +457,19 @@ jobs: "arch": "amd64", "cpu": "x86_64", "os": "Windows", - "triple": "x86_64-unknown-windows-msvc", + "triple": "x86_64-unknown-windows-msvc" }, { "arch": "arm64", "cpu": "aarch64", "os": "Windows", - "triple": "aarch64-unknown-windows-msvc", + "triple": "aarch64-unknown-windows-msvc" }, { "arch": "x86", "cpu": "i686", "os": "Windows", - "triple": "i686-unknown-windows-msvc", + "triple": "i686-unknown-windows-msvc" } ] } @@ -479,12 +479,12 @@ jobs: { "arch": "x86_64", "cpu": "x86_64", - "os": "Darwin", + "os": "Darwin" }, { "arch": "arm64", "cpu": "arm64", - "os": "Darwin", + "os": "Darwin" } ] } @@ -495,7 +495,7 @@ jobs: "arch": "arm64", "cpu": "arm64", "os": "Darwin", - "triple": "arm64-apple-macosx15.0", + "triple": "arm64-apple-macosx15.0" } ] } @@ -506,13 +506,13 @@ jobs: "arch": "x86_64", "cpu": "x86_64", "os": "Darwin", - "triple": "x86_64-apple-macosx15.0", + "triple": "x86_64-apple-macosx15.0" }, { "arch": "arm64", "cpu": "arm64", "os": "Darwin", - "triple": "arm64-apple-macosx15.0", + "triple": "arm64-apple-macosx15.0" } ] }