From 32e8df2ffed3224d043feebfd04baba149bca0cd Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Tue, 7 Oct 2025 10:05:59 -0700 Subject: [PATCH 1/2] Add new smoke test for swift-issue-reporting --- .github/workflows/swift-toolchain.yml | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/swift-toolchain.yml b/.github/workflows/swift-toolchain.yml index c0f0b4eaa..213f8cf27 100644 --- a/.github/workflows/swift-toolchain.yml +++ b/.github/workflows/swift-toolchain.yml @@ -5575,6 +5575,13 @@ jobs: path: ${{ github.workspace }}/SourceCache/swift-win32 show-progress: false + - uses: actions/checkout@v4.2.2 + with: + repository: pointfreeco//swift-issue-reporting + ref: refs/heads/main + path: ${{ github.workspace }}/SourceCache/swift-issue-reporting + show-progress: false + - name: Download Swift SDK Installer (${{ inputs.release && 'online' || 'offline' }}) uses: actions/download-artifact@v4 with: @@ -5615,11 +5622,17 @@ jobs: echo "$env:Path" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 Get-ChildItem Env: | % { echo "$($_.Name)=$($_.Value)" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append } - - run: swift build + - name: Smoke swift-win32 working-directory: ${{ github.workspace }}/SourceCache/swift-win32 + run: | + swift build + swift test -Xswiftc -DENABLE_TESTING - - run: swift test -Xswiftc -DENABLE_TESTING - working-directory: ${{ github.workspace }}/SourceCache/swift-win32 + - name: Smoke swift-issue-reporting + working-directory: ${{ github.workspace }}/SourceCache/swift-issue-reporting + run: | + swift build -c release + swift test -c release # Ensures redistributables contain all expected DLLs. redistributable_smoke_test: From e4c61b6b69b128f755b5088b00e3701aa0178b53 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Tue, 7 Oct 2025 16:26:49 -0700 Subject: [PATCH 2/2] Code review comments --- .github/workflows/swift-toolchain.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/swift-toolchain.yml b/.github/workflows/swift-toolchain.yml index 213f8cf27..f4d777dab 100644 --- a/.github/workflows/swift-toolchain.yml +++ b/.github/workflows/swift-toolchain.yml @@ -5577,7 +5577,7 @@ jobs: - uses: actions/checkout@v4.2.2 with: - repository: pointfreeco//swift-issue-reporting + repository: pointfreeco/swift-issue-reporting ref: refs/heads/main path: ${{ github.workspace }}/SourceCache/swift-issue-reporting show-progress: false @@ -5622,13 +5622,13 @@ jobs: echo "$env:Path" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 Get-ChildItem Env: | % { echo "$($_.Name)=$($_.Value)" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append } - - name: Smoke swift-win32 + - name: Build & Test compnerd/swift-win32 working-directory: ${{ github.workspace }}/SourceCache/swift-win32 run: | swift build swift test -Xswiftc -DENABLE_TESTING - - name: Smoke swift-issue-reporting + - name: Build & Test pointfreeco/swift-issue-reporting working-directory: ${{ github.workspace }}/SourceCache/swift-issue-reporting run: | swift build -c release