-
Notifications
You must be signed in to change notification settings - Fork 9
Core: add SignedNumeric protocol
#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SignedNumeric protocolSignedNumeric protocol
|
Interesting, sounds like we are missing some requirements that the compiler expected? We should try to identify what those requirements are at the very least before we merge this I think. |
|
A lot of numerical stuff requires a huge amount of operators and their dependencies introduced at once. I had to omit some of those to split it into separate PRs. Would you find it acceptable if I don't omit anything and submit things without breaking these cyclic dependencies? That would result in huge PRs. |
|
I think that if we know/understand what is missing and having that as FIXMEs is fine. We need to break the dependency cycle somewhere and I think that doing that iteratively is going to be easier. |
|
Main blocker for me here is |
|
Perfet! At least we understand what is missing and why, so I don't see that as a blocker for making progress. |
|
Great, that's ready now. |
Depends on #55.
I'm not adding the default (and only) implementation here yet, as it crashes the type checker with
Assertion failed: (protocol && "requirements should have stopped recursion")error message: