Skip to content

Upgraded axe-core to 4.0.2 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vnorekyan wants to merge 4 commits into from
Closed

Upgraded axe-core to 4.0.2 #59

vnorekyan wants to merge 4 commits into from

Conversation

@vnorekyan
Copy link

@vnorekyan vnorekyan commented Sep 1, 2020

Addressing issue #58

@timfisher
Copy link

timfisher commented Sep 30, 2020

Is it possible to merge this please?

@Brynman
Copy link

Brynman commented Oct 7, 2020

We would also be very interested in this.

@vnorekyan
Copy link
Author

vnorekyan commented Oct 7, 2020 •
edited
Loading

@timfisher @Brynman I don't have write access, so I can't merge this, can someone else with write access do that?

@vnorekyan vnorekyan changed the title Upgraded axe-core to 4.0.1 Upgraded axe-core to 4.0.2 Oct 7, 2020
sapegin
sapegin reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

I've changed the way the code is bundled in #69, so axe-core isn't bundled anymore, but a peer dependency, it also allows axe-core 4.x.

@sapegin sapegin mentioned this pull request Oct 26, 2020
Closed
sapegin added a commit that referenced this pull request Oct 27, 2020
@sapegin
feat: Don't bundle axe-core
957b8c8 
This allows consumers to use their own version of axe-core and significantly reduces the installation size. Also allow any 3.x or 4.x versions of axe-core in peer dependencies.

Closes #65, closes #59
@sapegin sapegin mentioned this pull request Oct 27, 2020
Merged
@sapegin sapegin closed this in #69 Oct 27, 2020
sapegin added a commit that referenced this pull request Oct 27, 2020
@sapegin
feat: Don't bundle axe-core (#69)
71e3a50 
This allows consumers to use their own version of axe-core and significantly reduces the installation size. Also allow any 3.x or 4.x versions of axe-core in peer dependencies.

Closes #65, closes #59
@github-actions
Copy link

github-actions bot commented Oct 27, 2020

🎉 This issue has been resolved in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapegin sapegin sapegin left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vnorekyan @timfisher @Brynman @sapegin