Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

positioning is backwards? #11

Closed
ianstormtaylor opened this Issue · 11 comments

5 participants

@ianstormtaylor

hey TJ, sorry if this is dumb. really confused here.

seems like north is now south? i assumed north meant the tooltip was going to be "north" of the element. not that the arrow would point north. slash also the pic in the readme seems to back this up. but this commit undid this very purposefully so i'm wondering what's up: 9493a28

and then also, wondering what this hard-coded padding is for: https://github.com/ianstormtaylor/tip/blob/9493a28545977b896dec7003ce79d9ef4d980cbf/index.js#L264 i'm looking at improving the way the arrows are positioned and was thinking i might have a crack at removing it, but wanted to make sure i understood it properly first.

@rauchg
Owner

I believe the positioning keywords now match jquery tipsy's.
-1 on hard coded padding

@tj
Owner
tj commented

we recently changed it to match tipsy so now you specify the position of the tip arrow and not the position relative to the element, it's a little counter-intuitive though. The padding is a lame hack for this other lame hack: component/aurora-tip@3071e30#L0R82

@ianstormtaylor

tipsy :unamused: is it worth having that consistency?

also, should the default now be south then? tooltips underneath feels weird to me

haha alright im not going to go anywhere near that then since i dont use the diagonal ones yet

@ianstormtaylor

ah wow just looked up and tipsy's default is below. makes me question more whether we want that kind of consistency.

what if we changed to top/left/etc like this issue wants so it's less similar to tipsys api, and then went with the nicer defaults and less confusing positioning system?

@tj
Owner
tj commented

ah yeah we should tweak the default I agree with that for sure. north/south etc is kinda awkward IMO anyway, I'd love to have those aliases they make more sense to me

@ianstormtaylor

you want them as aliases or as the way to do it?

i was thinking of removing north/south and going with top/bottom, but also using the more intuitive way where top is above, etc.

@tj
Owner
tj commented

aliases for now at least, it gets a little weird once you get into the ones like "north east", to me those ones make more sense to specify the arrow, I dont know haha

@ianstormtaylor

top-left seems pretty intuitive to me, instead of south-east. whenever i'm actually wanting to position a tooltip, i'm always thinking "where do i want this tooltip to go?" "on top"

@tj
Owner
tj commented

yeah I agree, the top/left etc just don't line up 1-1 with our current positioning that's all (not a big deal though). When you do south-west the tip itself isn't at the top left, it's still centered and the arrow is on the left, that's where I think it's weird beyond top/left/bottom/right. However a real "top left" etc is probably more useful for popovers

@dominicbarnes

Ah, I was very confused by the positioning as well. I've never used tipsy, and I kept searching in the code for an explanation because I was sure I was doing something wrong.

Can the preview image in the README be updated? (it shows "north" for a tooltip that now is actually "south") Or at the very least could further description be added to the Tip#position() documentation?

@pirxpilot
Owner

fixed by #23

@pirxpilot pirxpilot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.