Error thrown when attempting to hide a fixed position tip #25

Closed
pushchris opened this Issue Oct 25, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@pushchris

When a fixed position tip is added, the events for resize and scroll are not bound so when removing the tip an error gets thrown.

@pirxpilot

This comment has been minimized.

Show comment Hide comment
@pirxpilot

pirxpilot Apr 8, 2014

Owner

Not a problem any more, since component/events can handle unbinding even if no events were bound.
That said, to be on the safe side we should just probably call winEvents.unbind() (with no params) in Tip.hide
If you think it's still a problem please add a test case to index.html that reproduces it.

Owner

pirxpilot commented Apr 8, 2014

Not a problem any more, since component/events can handle unbinding even if no events were bound.
That said, to be on the safe side we should just probably call winEvents.unbind() (with no params) in Tip.hide
If you think it's still a problem please add a test case to index.html that reproduces it.

@pirxpilot pirxpilot closed this Apr 8, 2014

pirxpilot added a commit that referenced this issue Apr 8, 2014

improve binding of 'scroll' and 'resize' handlers
ensure that 'scroll' and 'resize' handlers are in all cases bound at
most once, and that they are always unbound when Tip is removed

fixes #38
fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment